Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack trace ante un error no reconoce el body de un método o test #313

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

fdodino
Copy link
Contributor

@fdodino fdodino commented Nov 17, 2024

Dejo un WIP para poder pelotearlo en alguna juntada de los martes. Ver más detalle en #302

fdodino and others added 2 commits November 17, 2024 09:30
  - Rollback changes in interpret
  - Fixing tests
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.73%. Comparing base (25de9db) to head (9d9a306).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/interpreter/interpreter.ts 41.66% 7 Missing ⚠️
src/interpreter/runtimeModel.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   89.76%   89.73%   -0.03%     
==========================================
  Files          28       28              
  Lines        3175     3176       +1     
  Branches      576      576              
==========================================
  Hits         2850     2850              
- Misses        169      170       +1     
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PalumboN PalumboN marked this pull request as ready for review November 19, 2024 23:05
@PalumboN
Copy link
Contributor

Acá coverage la está flasheando, no? Se mergea?

@fdodino
Copy link
Contributor Author

fdodino commented Nov 19, 2024

Acá coverage la está flasheando, no? Se mergea?

a la gilada y a codecov, ni cabida!
yo mergeo desde arriba!!

@PalumboN PalumboN merged commit 5cfb448 into master Nov 26, 2024
2 of 4 checks passed
@PalumboN PalumboN deleted the fix-#302-assertion-errors branch November 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants