Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic behind presence check in text_explain #140

Open
hshany opened this issue Aug 14, 2023 · 0 comments
Open

Logic behind presence check in text_explain #140

hshany opened this issue Aug 14, 2023 · 0 comments

Comments

@hshany
Copy link

hshany commented Aug 14, 2023

Thanks for the wonderful tool. I'm testing the library by following the tutorial with some of my own prediction models. I noticed that the text explanation is a filtered list of the descriptors displayed on the images. Based on the code, part of the filter is a check on the presence_threshold. What is the logic behind this check? From the code one can infer that in the case where present=nbases=1, the condition "if present / nbases < (1 - presence_thresh) and v < 0" will always fail for negatively contributing descriptors with finite presence_thresh, which means negatively contributing descriptors will always be excluded from the text description. Is there a rational supporting such exclusion?

https://github.com/ur-whitelab/exmol/blob/67873897bbcd2deb60c69a5116bc7feea69fdefa/exmol/exmol.py#L1462C1-L1475C21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant