Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagged reports shouldn't be returned by the server #99

Open
abrahamq opened this issue Oct 31, 2018 · 0 comments
Open

Flagged reports shouldn't be returned by the server #99

abrahamq opened this issue Oct 31, 2018 · 0 comments
Assignees

Comments

@abrahamq
Copy link
Member

When you flag a report using the authenticated api, the flag json key is added and set to true in
properties-> report_data -> flag, but the report is still returned by the GET /reports endpoint.

It seems that if we have flagged a report then we shouldn't return it for anyone else to use it/ for it to show up on the public facing map. We could make a note that consumers of GET /reports should check this flag variable, but that seems brittle.

I think that the server should not return reports that are flagged (except maybe if we ask for them by id?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants