Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talk dialog bubbles don't appear above NPCs during festivals #31

Open
PhantomBull opened this issue Apr 29, 2024 · 3 comments
Open

Talk dialog bubbles don't appear above NPCs during festivals #31

PhantomBull opened this issue Apr 29, 2024 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@PhantomBull
Copy link

Steps to reproduce:

  • Set Config.DisplayTalkPrompts to true
  • Go to a festival location during a festival

Expected behavior:
Bubbles with the talk icon are displayed above the NPCs I didn't talk during that day

Current behavior:
There's no bubbles above any NPC

@urbanyeti
Copy link
Owner

If I’m understanding the issue correctly, I think this is working as intended and more related to how the game is coded. I think the conversations during events and festival don’t “count” as having had a conversation with the NPC for the purposes of improving or preserving the friendship. This can be verified by looking at the journal entry for the NPC after talking to them at a festival and seeing if there’s a check next to the dialogue icon.

@PhantomBull
Copy link
Author

PhantomBull commented May 1, 2024

I just checked it and before talking to them they don't have a check, and after talking to them they do, so it does count for improving friendship. What we can't do during the festivals is giving them gifts.

@urbanyeti
Copy link
Owner

Oooh, okay-- thanks for checking! Not sure why I thought that. I'll try to get them working in festivals in my next update.

@urbanyeti urbanyeti self-assigned this May 3, 2024
@urbanyeti urbanyeti added this to the Release 1.1.3 milestone May 3, 2024
@urbanyeti urbanyeti added the bug Something isn't working label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants