From 8a8bdd9c537757b1b083e03851b84f181e986c85 Mon Sep 17 00:00:00 2001
From: Weronika Tomaszewska <veratomaszewska@gmail.com>
Date: Fri, 15 Nov 2024 14:47:45 -0500
Subject: [PATCH] CPF-492 Add "Only Treasury Uploads" filter (#504)

* CPF-492 add treasury uploads filter, add global filter option to table builder component

* sort uploads in desc order, by createdAt date

* remove lodash import

* remove interface

* add id to treasury checkbox to make the label clickable
---
 api/src/graphql/uploads.sdl.ts                |  1 +
 api/src/services/uploads/uploads.ts           |  1 +
 .../components/TableBuilder/TableBuilder.tsx  | 66 +++++++++++++------
 web/src/components/Upload/Uploads/Uploads.tsx | 20 +++++-
 .../Upload/UploadsCell/UploadsCell.tsx        | 59 ++++++++++++++++-
 5 files changed, 126 insertions(+), 21 deletions(-)

diff --git a/api/src/graphql/uploads.sdl.ts b/api/src/graphql/uploads.sdl.ts
index 12f56e4b..403d1c10 100644
--- a/api/src/graphql/uploads.sdl.ts
+++ b/api/src/graphql/uploads.sdl.ts
@@ -21,6 +21,7 @@ export const schema = gql`
   type Query {
     uploads: [Upload!]! @requireAuth
     upload(id: Int!): Upload @requireAuth
+    getValidUploadsInCurrentPeriod: [Upload!]! @requireAuth
   }
 
   input CreateUploadInput {
diff --git a/api/src/services/uploads/uploads.ts b/api/src/services/uploads/uploads.ts
index b60062e6..5de1f2d5 100644
--- a/api/src/services/uploads/uploads.ts
+++ b/api/src/services/uploads/uploads.ts
@@ -42,6 +42,7 @@ export const uploads: QueryResolvers['uploads'] = () => {
 
   return db.upload.findMany({
     where: whereInputs,
+    orderBy: { createdAt: 'desc' },
   })
 }
 
diff --git a/web/src/components/TableBuilder/TableBuilder.tsx b/web/src/components/TableBuilder/TableBuilder.tsx
index 267f1dd6..2ecb3b69 100644
--- a/web/src/components/TableBuilder/TableBuilder.tsx
+++ b/web/src/components/TableBuilder/TableBuilder.tsx
@@ -7,7 +7,7 @@ import {
   getFilteredRowModel,
   ColumnFiltersState,
 } from '@tanstack/react-table'
-import { Button } from 'react-bootstrap'
+import { Button, Form } from 'react-bootstrap'
 import Table from 'react-bootstrap/Table'
 
 import TableHeader from './TableHeader'
@@ -16,9 +16,9 @@ import TableRow from './TableRow'
 /*
   This component uses TanStack Table to add filtering
   and sorting functionality.
-  For documentation, visit: https://tanstack.com/table/v8/docs/guide/introduction
+  For documentation, visit: https://tanstack.com/table/v8/docs/introduction
 */
-function TableBuilder({ data, columns, filterableInputs = [] }) {
+function TableBuilder({ data, columns, filterableInputs = [], globalFilter }) {
   const [columnFilters, setColumnFilters] = useState<ColumnFiltersState>([])
   const [sorting, setSorting] = useState([])
 
@@ -36,25 +36,57 @@ function TableBuilder({ data, columns, filterableInputs = [] }) {
     getFilteredRowModel: getFilteredRowModel(),
   })
 
-  const resetColumnFilters = () => {
+  const resetFilters = () => {
     table.resetColumnFilters()
+    if (globalFilter) {
+      globalFilter.onChange()
+    }
+  }
+
+  const renderTableBody = () => {
+    const rows = table.getRowModel().rows
+
+    if (!rows.length) {
+      return (
+        <tr className="border">
+          <td colSpan={100} className="text-center py-4">
+            <span className="text-muted">No results found</span>
+          </td>
+        </tr>
+      )
+    }
+
+    return rows.map((row) => <TableRow row={row} key={row.id} />)
   }
 
   return (
     <div className="p-2">
       <Table striped borderless>
         <thead>
-          {!!filterableInputs.length && (
+          {(!!filterableInputs.length || globalFilter) && (
             <tr className="border">
-              <th className="text-end" colSpan={100}>
-                <Button
-                  className="btn btn-secondary"
-                  size="sm"
-                  onClick={resetColumnFilters}
-                >
-                  Reset filters
-                </Button>
-              </th>
+              <td colSpan={100} className="text-end pe-2">
+                <div className="d-inline-flex align-items-center gap-3">
+                  {globalFilter && (
+                    <Form.Check
+                      type="checkbox"
+                      id="treasury-files-filter"
+                      label={globalFilter.label}
+                      checked={globalFilter.checked}
+                      onChange={globalFilter.onChange}
+                      disabled={globalFilter.loading}
+                      className="mb-0"
+                    />
+                  )}
+                  <Button
+                    className="btn btn-secondary"
+                    size="sm"
+                    onClick={resetFilters}
+                  >
+                    Reset filters
+                  </Button>
+                </div>
+              </td>
             </tr>
           )}
           {table.getHeaderGroups().map((headerGroup) => (
@@ -65,11 +97,7 @@ function TableBuilder({ data, columns, filterableInputs = [] }) {
             />
           ))}
         </thead>
-        <tbody>
-          {table.getRowModel().rows.map((row) => (
-            <TableRow row={row} key={row.id} />
-          ))}
-        </tbody>
+        <tbody>{renderTableBody()}</tbody>
       </Table>
     </div>
   )
diff --git a/web/src/components/Upload/Uploads/Uploads.tsx b/web/src/components/Upload/Uploads/Uploads.tsx
index 89235955..8f27a8d0 100644
--- a/web/src/components/Upload/Uploads/Uploads.tsx
+++ b/web/src/components/Upload/Uploads/Uploads.tsx
@@ -4,7 +4,19 @@ import TableBuilder from 'src/components/TableBuilder/TableBuilder'
 
 import { columnDefs } from './columns'
 
-const UploadsList = ({ uploads }: FindUploads) => {
+interface UploadsListProps {
+  uploads: FindUploads['uploads']
+  showTreasuryFiles: boolean
+  onTreasuryFilesChange: () => void
+  isLoading?: boolean
+}
+
+const UploadsList = ({
+  uploads,
+  showTreasuryFiles,
+  onTreasuryFilesChange,
+  isLoading,
+}: UploadsListProps) => {
   const filterableInputs = [
     'agency_code',
     'expenditureCategory_code',
@@ -18,6 +30,12 @@ const UploadsList = ({ uploads }: FindUploads) => {
       data={uploads}
       columns={columnDefs}
       filterableInputs={filterableInputs}
+      globalFilter={{
+        label: 'Only Treasury Files',
+        checked: showTreasuryFiles,
+        onChange: onTreasuryFilesChange,
+        loading: isLoading,
+      }}
     />
   )
 }
diff --git a/web/src/components/Upload/UploadsCell/UploadsCell.tsx b/web/src/components/Upload/UploadsCell/UploadsCell.tsx
index c3b0b067..58baa085 100644
--- a/web/src/components/Upload/UploadsCell/UploadsCell.tsx
+++ b/web/src/components/Upload/UploadsCell/UploadsCell.tsx
@@ -1,7 +1,10 @@
+import { useState } from 'react'
+
 import type { FindUploads } from 'types/graphql'
 
 import { Link, routes } from '@redwoodjs/router'
 import type { CellSuccessProps, CellFailureProps } from '@redwoodjs/web'
+import { useQuery } from '@redwoodjs/web'
 
 import Uploads from 'src/components/Upload/Uploads'
 
@@ -39,6 +42,40 @@ export const QUERY = gql`
   }
 `
 
+export const VALID_UPLOADS_QUERY = gql`
+  query GetValidUploadsInCurrentPeriod {
+    getValidUploadsInCurrentPeriod {
+      id
+      filename
+      uploadedBy {
+        id
+        email
+      }
+      agency {
+        id
+        code
+      }
+      expenditureCategory {
+        id
+        code
+      }
+      reportingPeriod {
+        id
+        name
+      }
+      latestValidation {
+        id
+        createdAt
+        passed
+        isManual
+        results
+      }
+      createdAt
+      updatedAt
+    }
+  }
+`
+
 export const Loading = () => <div>Loading...</div>
 
 export const Empty = () => {
@@ -57,5 +94,25 @@ export const Failure = ({ error }: CellFailureProps) => (
 )
 
 export const Success = ({ uploads }: CellSuccessProps<FindUploads>) => {
-  return <Uploads uploads={uploads} />
+  const [showTreasuryFiles, setShowTreasuryFiles] = useState(false)
+  const { data: validUploadsData, loading: validUploadsLoading } = useQuery(
+    VALID_UPLOADS_QUERY,
+    {
+      skip: !showTreasuryFiles,
+    }
+  )
+
+  const displayedUploads =
+    showTreasuryFiles && validUploadsData
+      ? validUploadsData.getValidUploadsInCurrentPeriod
+      : uploads
+
+  return (
+    <Uploads
+      uploads={displayedUploads}
+      showTreasuryFiles={showTreasuryFiles}
+      onTreasuryFilesChange={() => setShowTreasuryFiles(!showTreasuryFiles)}
+      isLoading={validUploadsLoading}
+    />
+  )
 }