From 0666d17b25f380a5892190592527a4c4a7af6903 Mon Sep 17 00:00:00 2001 From: adele-usdr <146878468+adele-usdr@users.noreply.github.com> Date: Thu, 14 Dec 2023 16:53:56 -0800 Subject: [PATCH] #2337: New feature flag for moving Grant Details from a modal to an independent page (#2338) * fix: copy GrantDetails.vue and make GrantDetailsLegacy.vue for the old modal * fix: fixing a link path * fix: add initial feature flag * fix: use existing modal GrantDetails only if the new feature flag is turned off * fix: rename modal control to GrantDetailsLegacy --- packages/client/public/deploy-config.js | 1 + .../client/src/components/GrantsTable.vue | 11 +- ...rantDetails.vue => GrantDetailsLegacy.vue} | 0 .../client/src/helpers/featureFlags/index.js | 4 + packages/client/src/views/Dashboard.vue | 11 +- packages/client/src/views/GrantDetails.vue | 275 ++++++++++++++++++ packages/client/src/views/RecentActivity.vue | 10 +- .../client/src/views/UpcomingClosingDates.vue | 10 +- terraform/prod.tfvars | 5 +- terraform/sandbox.tfvars | 5 +- terraform/staging.tfvars | 5 +- 11 files changed, 317 insertions(+), 20 deletions(-) rename packages/client/src/components/Modals/{GrantDetails.vue => GrantDetailsLegacy.vue} (100%) create mode 100644 packages/client/src/views/GrantDetails.vue diff --git a/packages/client/public/deploy-config.js b/packages/client/public/deploy-config.js index 8d0b32431..2146385e4 100644 --- a/packages/client/public/deploy-config.js +++ b/packages/client/public/deploy-config.js @@ -22,4 +22,5 @@ window.APP_CONFIG.overrideFeatureFlag = (flagName, overrideValue) => { window.APP_CONFIG.featureFlags = { myProfileEnabled: true, newTerminologyEnabled: true, + newGrantsDetailPageEnabled: false, }; diff --git a/packages/client/src/components/GrantsTable.vue b/packages/client/src/components/GrantsTable.vue index 4ef439527..d3a55e08c 100644 --- a/packages/client/src/components/GrantsTable.vue +++ b/packages/client/src/components/GrantsTable.vue @@ -70,22 +70,22 @@
{{ totalRows }} total grant{{ totalRows == 1 ? '' : 's' }}
- + diff --git a/packages/client/src/views/RecentActivity.vue b/packages/client/src/views/RecentActivity.vue index 2e5f3bea4..796add73a 100644 --- a/packages/client/src/views/RecentActivity.vue +++ b/packages/client/src/views/RecentActivity.vue @@ -55,7 +55,7 @@ aria-controls="grants-table" /> {{ grantsInterested.length }} of {{ totalRows }} - +