Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old Grants table implementation and feature flag #2218

Closed
adele-usdr opened this issue Nov 14, 2023 · 0 comments · Fixed by #2303
Closed

Remove old Grants table implementation and feature flag #2218

adele-usdr opened this issue Nov 14, 2023 · 0 comments · Fixed by #2303
Assignees
@adele-usdr
Labels
Grant Finder Issues related to the Grant Finder

Comments

@adele-usdr
Copy link
Contributor

Why is this issue important?

Discussed in Grants Finder meeting that we are ready to remove the old grants table implementation. We should rename the new one, so there's only one grants table when folks go looking for it.

Current State

The in-use grants table is GrantsTableNext.vue and the old one is GrantsTable.vue

Expected State

Current grants table implementation should be at GrantsTable.vue.

Implementation Plan

Move current implementation to GrantsTable.vue, remove feature flag.

Relevant Code Snippets

No response
@adele-usdr adele-usdr changed the title Remove old Grants table implementation Remove old Grants table implementation and feature flag Nov 14, 2023
@adele-usdr adele-usdr self-assigned this Nov 14, 2023
@ClaireValdivia ClaireValdivia added the Grant Finder Issues related to the Grant Finder label Nov 14, 2023
adele-usdr added a commit that referenced this issue Nov 14, 2023
@adele-usdr
fix: #2218 remove grants table feature flag, and logic specific to ol…
2042b2b 
…d grants table
@ClaireValdivia ClaireValdivia moved this from 🆕 New to 📋 Scoping in Grants Team Agile Planning Nov 29, 2023
@ClaireValdivia ClaireValdivia moved this from 📋 Scoping to 🔖 Ready in Grants Team Agile Planning Dec 1, 2023
adele-usdr added a commit that referenced this issue Dec 4, 2023
@adele-usdr
fix: #2218 remove grants table feature flag, and logic specific to ol…
e6ff1d1 
…d grants table
@adele-usdr adele-usdr linked a pull request Dec 4, 2023 that will close this issue
2218 remove old grants table implementation and feature flag #2303
Merged
3 tasks
@adele-usdr adele-usdr mentioned this issue Dec 4, 2023
Merged
3 tasks
@adele-usdr adele-usdr moved this from 🔖 Ready to 👀 In review in Grants Team Agile Planning Dec 5, 2023
adele-usdr added a commit that referenced this issue Dec 8, 2023
@adele-usdr @TylerHendrickson
2218 remove old grants table implementation and feature flag (#2303)
e69809b 
* fix: #2218 remove grants table feature flag, and logic specific to old grants table

* fix: moving GrantsTableNext.vue to GrantsTable.vue

* fix: remove use of GrantsTableNext completely

* fix: remove stray newline

* fix: removed some additional instances of the flag

---------

Co-authored-by: Tyler Hendrickson <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Staging in Grants Team Agile Planning Dec 8, 2023
adele-usdr added a commit that referenced this issue Dec 8, 2023
@adele-usdr
fix: #2218 remove last use of the useNewTable feature flag
19e6155
@adele-usdr adele-usdr mentioned this issue Dec 8, 2023
Merged
@adele-usdr adele-usdr moved this from ✅ Staging to 👀 In review in Grants Team Agile Planning Dec 8, 2023
@adele-usdr adele-usdr moved this from 👀 In review to 🏗 In progress in Grants Team Agile Planning Dec 12, 2023
adele-usdr added a commit that referenced this issue Dec 12, 2023
@adele-usdr
fix: #2218 Additional cleanup from removing useNewTable feature flag (#…
7d4d4ee 
…2324)

* fix: #2218 remove last use of the useNewTable feature flag

* fix: remove GrantsTableNext.vue
@adele-usdr adele-usdr moved this from 🏗 In progress to ✅ Staging in Grants Team Agile Planning Dec 12, 2023
@sanason sanason mentioned this issue Dec 15, 2023
Merged
7 tasks
@ClaireValdivia ClaireValdivia moved this from ✅ Staging to 🚢 Completed in Grants Team Agile Planning Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adele-usdr adele-usdr

Labels
Grant Finder Issues related to the Grant Finder
Projects
Grants Team Agile Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2218 remove old grants table implementation and feature flag usdigitalresponse/usdr-gost
2 participants
@ClaireValdivia @adele-usdr