-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change url for grant detail pages #2717
Labels
Comments
ClaireValdivia
added
grant details
Grant Finder
Issues related to the Grant Finder
labels
Mar 5, 2024
@jeffsmohan are you able to add technical implementation details to this issue? |
✅ Added implementation details |
LGTM! |
looks good in staging! |
github-project-automation
bot
moved this from 🚢 Completed
to ✅ Staging
in Grants Team Agile Planning
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Why is this issue important?
Want to implement hierarchical url structure for added discoverability
Current State
grant detail pages are following "grant/:id"
Expected State
grant detail pages should be "grants/:id"
Implementation Plan
/grant/:id
to/grants/:id
{name: 'grantDetail', params: {id: item.grant_id}}
) instead of building route strings (grant/${item.grant_id}
) to make them less brittle to changes like this, easier to type in the future, etc.Relevant Code Snippets
No response
The text was updated successfully, but these errors were encountered: