Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change url for grant detail pages #2717

Closed
ClaireValdivia opened this issue Mar 5, 2024 · 4 comments
Closed

Change url for grant detail pages #2717

ClaireValdivia opened this issue Mar 5, 2024 · 4 comments
Assignees
Labels
grant details Grant Finder Issues related to the Grant Finder

Comments

@ClaireValdivia
Copy link
Contributor

ClaireValdivia commented Mar 5, 2024

Why is this issue important?

Want to implement hierarchical url structure for added discoverability

Current State

grant detail pages are following "grant/:id"

Expected State

grant detail pages should be "grants/:id"

Implementation Plan

  1. Update the path in our router definition from /grant/:id to /grants/:id
  2. Update the three points in the code that route to the grant detail page (https://github.com/search?q=repo%3Ausdigitalresponse%2Fusdr-gost+grant%2F%24%7Bitem.grant_id%7D&type=code)
    • We should update these to use named routes ({name: 'grantDetail', params: {id: item.grant_id}}) instead of building route strings (grant/${item.grant_id}) to make them less brittle to changes like this, easier to type in the future, etc.
  3. The in-flight (Update emails to point to new Grant Details page #2705) email updates will need to link to the new URL.

Relevant Code Snippets

No response

@ClaireValdivia
Copy link
Contributor Author

@jeffsmohan are you able to add technical implementation details to this issue?

@jeffsmohan
Copy link
Contributor

✅ Added implementation details

@TylerHendrickson
Copy link
Member

LGTM!

@ClaireValdivia ClaireValdivia moved this from 📋 Scoping to 🔖 Ready in Grants Team Agile Planning Mar 7, 2024
@jeffsmohan jeffsmohan self-assigned this Mar 7, 2024
@jeffsmohan jeffsmohan moved this from 🔖 Ready to 🏗 In progress in Grants Team Agile Planning Mar 7, 2024
@jeffsmohan jeffsmohan moved this from 🏗 In progress to 👀 In review in Grants Team Agile Planning Mar 7, 2024
@jeffsmohan jeffsmohan moved this from 👀 In review to ✅ Staging in Grants Team Agile Planning Mar 11, 2024
@ClaireValdivia
Copy link
Contributor Author

looks good in staging!

@ClaireValdivia ClaireValdivia moved this from ✅ Staging to 🚢 Completed in Grants Team Agile Planning Mar 14, 2024
@sanason sanason closed this as completed Apr 19, 2024
@github-project-automation github-project-automation bot moved this from 🚢 Completed to ✅ Staging in Grants Team Agile Planning Apr 19, 2024
@ClaireValdivia ClaireValdivia moved this from ✅ Staging to 🚢 Completed in Grants Team Agile Planning Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grant details Grant Finder Issues related to the Grant Finder
Projects
Archived in project
Development

No branches or pull requests

4 participants