From 84e54d5f5de5fa1ab7465cff5665bc8605c79252 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Kwiecin=CC=81ski?= Date: Thu, 29 Jun 2023 22:55:59 +0200 Subject: [PATCH 1/3] Bump ktlint to 0.50.0 --- gradle/libs.versions.toml | 2 +- .../kotlin/io/github/usefulness/functional/ReportersTest.kt | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 0e9ed67c..6438a477 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -5,7 +5,7 @@ gradle-doctor = "0.8.1" google-agp = "8.0.2" maven-junit = "5.9.3" maven-assertj = "3.24.2" -maven-ktlint = "0.49.1" +maven-ktlint = "0.50.0" maven-commons = "2.13.0" [libraries] diff --git a/ktlint-gradle-plugin/src/test/kotlin/io/github/usefulness/functional/ReportersTest.kt b/ktlint-gradle-plugin/src/test/kotlin/io/github/usefulness/functional/ReportersTest.kt index d9cf0058..5ea21a64 100644 --- a/ktlint-gradle-plugin/src/test/kotlin/io/github/usefulness/functional/ReportersTest.kt +++ b/ktlint-gradle-plugin/src/test/kotlin/io/github/usefulness/functional/ReportersTest.kt @@ -6,6 +6,7 @@ import io.github.usefulness.functional.utils.settingsFile import org.assertj.core.api.Assertions.assertThat import org.gradle.testkit.runner.TaskOutcome import org.junit.jupiter.api.BeforeEach +import org.junit.jupiter.api.Disabled import org.junit.jupiter.api.Test import org.junit.jupiter.api.condition.DisabledOnOs import org.junit.jupiter.api.condition.OS @@ -97,6 +98,7 @@ class ReportersTest : WithGradleTest.Kotlin() { } @Test + @Disabled("ktlint doesn't maintain binary compatibility for some reason 🤷‍♂️") fun `uses reporters from overridden ktlint version`() { projectRoot.resolve("build.gradle") { // language=groovy From 8cc4fb354eb13bc51f26e98e02304f96f3192847 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 29 Jun 2023 21:01:27 +0000 Subject: [PATCH 2/3] Update dependency com.pinterest.ktlint:ktlint-cli-ruleset-core to v0.50.0 --- test-project-android/custom-ktlint-rules/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-project-android/custom-ktlint-rules/build.gradle b/test-project-android/custom-ktlint-rules/build.gradle index d3173dea..02f756fb 100644 --- a/test-project-android/custom-ktlint-rules/build.gradle +++ b/test-project-android/custom-ktlint-rules/build.gradle @@ -3,5 +3,5 @@ plugins { } dependencies { - compileOnly("com.pinterest.ktlint:ktlint-cli-ruleset-core:0.49.1") + compileOnly("com.pinterest.ktlint:ktlint-cli-ruleset-core:0.50.0") } From d291e3bf1191986231e7f4d698c0de82dc370199 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Kwiecin=CC=81ski?= Date: Thu, 29 Jun 2023 23:07:10 +0200 Subject: [PATCH 3/3] ktlint is not backwards compatible --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 29086729..99e8fc19 100644 --- a/README.md +++ b/README.md @@ -25,6 +25,7 @@ plugins { | plugin version | min gradle version | min ktlint version | |----------------|--------------------|--------------------| +| 0.4.0+ | 7.6 | 0.50.0 | | 0.3.0+ | 7.6 | 0.49.0 | | 0.1.0+ | 7.6 | 0.48.0 |