Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpsTransportSE completely ignores Proxy #204

Open
GoogleCodeExporter opened this issue Jul 9, 2015 · 2 comments
Open

HttpsTransportSE completely ignores Proxy #204

GoogleCodeExporter opened this issue Jul 9, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Create a java.net.Proxy instance
2. Try to establish an HTTPS connection using that proxy
3. Connection fails (generally a socket timeout will occur)

I've been browsing the sources of the project and found a major code mistake 
(probably due to a merge conflict which was not resolved thoroughly).

This commit introduced the Proxy feature: 
https://github.com/mosabua/ksoap2-android/commit/7ad1c53efdbc53ce7280de74ec792ef
c9f066e4f

If you look around line 65 of HttpsServiceConnectionSE.java you'll see that 
there's an "if statement" that is completely useless (the connection instance 
if overwritten at line 74).

This causes the proxy instance to be ignored for HTTPS connections.

Original issue reported on code.google.com by [email protected] on 26 Jan 2015 at 3:42

@GoogleCodeExporter
Copy link
Author

*is overwritten

Original comment by [email protected] on 26 Jan 2015 at 3:50

@GoogleCodeExporter
Copy link
Author

Want to send a  pull request that fixes the issue? 

Original comment by [email protected] on 27 Jan 2015 at 12:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant