Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix spelling errors #275 #274

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

bzarboni1
Copy link

@bzarboni1 bzarboni1 commented Aug 2, 2024

Committer Notes

#275 - The example files contain many typos

While browsing the example files, it was noted that there are many typos and spelling errors. For example:

  • examples\ap\*\ifa_assessment-plan-example.[json|xml|yaml]:
-                 <title>Obtain Applcation Access Provided by Product Team</title>
+                <title>Obtain Application Access Provided by Product Team</title>
  • examples\ap\*\ifa_assessment-results-example.[json|xml|yaml]:
-                <p>If such an insider threat existed and acted with this misconfigruatio, the
+                <p>If such an insider threat existed and acted with this misconfiguration, the
  • examples\ap\*\ifa_assessment-results-example.[json|xml|yaml]:
-                title: 'IFA-GOODREAD-RISK1-RESPONSE: IFA GoodRead Prouct Team Response'
+               title: 'IFA-GOODREAD-RISK1-RESPONSE: IFA GoodRead Product Team Response'

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
    n/a
  • Have you written new tests for your core changes, as applicable?
    n/a
  • Have you included examples of how to use your new feature(s)?
    n/a

@iMichaela
Copy link
Contributor

@bzarboni1 - Thank you for all the hard work captured in this PR.

  1. We have a pipeline that generates different formats of OSCAL examples, so the changes only need to be made in the
    src/examples subdirectory.
  2. Also, could you please submit the PR against the develop branch? It would be greatly appreciated.

@bzarboni1 bzarboni1 changed the base branch from main to develop August 6, 2024 12:59
@bzarboni1 bzarboni1 marked this pull request as draft August 6, 2024 13:06
@bzarboni1 bzarboni1 changed the title chore: fix spelling errors #2032 chore: fix spelling errors #275 Aug 6, 2024
@bzarboni1
Copy link
Author

@bzarboni1 - Thank you for all the hard work captured in this PR.

  1. We have a pipeline that generates different formats of OSCAL examples, so the changes only need to be made in the
    src/examples subdirectory.
  2. Also, could you please submit the PR against the develop branch? It would be greatly appreciated.

Thank you! Resubmitted.

@bzarboni1 bzarboni1 marked this pull request as ready for review August 6, 2024 13:17
@iMichaela
Copy link
Contributor

@bzarboni1 - Thank you for all the hard work captured in this PR.

  1. We have a pipeline that generates different formats of OSCAL examples, so the changes only need to be made in the
    src/examples subdirectory.
  2. Also, could you please submit the PR against the develop branch? It would be greatly appreciated.

Thank you! Resubmitted.

We thank you for your contributions ... and for carefully reading the information posted. Regrettably, many collaborators and our team members focused on the OSCAL structure and trusted the spelling of the developer.

@iMichaela iMichaela merged commit 9df3f15 into usnistgov:develop Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants