Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Compile - Feature: Allow users to configure Sass options #133

Open
2 tasks done
mahoneycm opened this issue Dec 10, 2024 · 0 comments
Open
2 tasks done

USWDS-Compile - Feature: Allow users to configure Sass options #133

mahoneycm opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels
Affects: Build Relates to the build process Affects: Compiling Related to compiling Sass or JavaScript Affects: Settings Relates to project settings Context: Sass Issue is in Sass Needs: Discussion Role: Dev Development/engineering skills needed Status: Triage We're triaging this issue and grooming if necessary Type: Feature Request New functionality

Comments

@mahoneycm
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Follow-up to #131

Currently, we specify a few settings that allow users to customize the Sass compilation (see README additional settings). Sass JS API offers additional options that give more control over the way Sass compiles styles.

Describe the solution you'd like

Ideally, we'll set good defaults but allow users to pass a map of Sass options that would then be passed into our Sass scripts.

Describe alternatives you've considered

No response

Additional context

Suggestion provided by @mdmower-csnw

I don't mean to rock the boat as this is an appreciated feature, but I think it's worth pointing out that there are other open issues that could be solved at the same time by simply allowing users to configure sass options. The approach I took in the fork we're using not only silences deprecations by default (i.e. good out of box experience), but it also:

  1. let's users fine-tune their deprecation notice preferences
  2. could satisfy USWDS-Compile - Feature: Allow users to define SASS output style #80 if a restriction I put in place is removed
  3. (I think) could satisfy USWDS-Compile - Feature: Ability to specify external packages #59 with a bit of effort in handling includes

Code of Conduct

@mahoneycm mahoneycm added Affects: Build Relates to the build process Affects: Compiling Related to compiling Sass or JavaScript Affects: Settings Relates to project settings Context: Sass Issue is in Sass Needs: Discussion Role: Dev Development/engineering skills needed Status: Triage We're triaging this issue and grooming if necessary Type: Feature Request New functionality labels Dec 10, 2024
@mahoneycm mahoneycm self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Build Relates to the build process Affects: Compiling Related to compiling Sass or JavaScript Affects: Settings Relates to project settings Context: Sass Issue is in Sass Needs: Discussion Role: Dev Development/engineering skills needed Status: Triage We're triaging this issue and grooming if necessary Type: Feature Request New functionality
Projects
Status: No status
Development

No branches or pull requests

1 participant