Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for complex numbers #47

Open
paulxshen opened this issue Oct 14, 2024 · 2 comments
Open

PR for complex numbers #47

paulxshen opened this issue Oct 14, 2024 · 2 comments

Comments

@paulxshen
Copy link

I needed the following to avoid errors (probably due to redundant type conversions in my code):
TrackedFloats.tf_untrack_complex(x::Complex32) = x
TrackedFloats.tf_track_complex(x::Complex{TrackedFloat32}) = x
etc...

@ashton314
Copy link
Member

ashton314 commented Oct 15, 2024

Hi there!

Please provide a complete minimal example that shows the undesired behavior, as well as a description of what you think the behavior should be.

Also, the title you gave us says "PR"—do you intend to submit a PR to fix this issue? (I've updated the title to replace #number; please do not use # as an abbreviation. Please update further to make the title more descriptive—in particular, do not put PR unless you really intend to submit a pull request.)

@ashton314 ashton314 changed the title PR for complex # PR for complex numbers Oct 15, 2024
@bennn
Copy link
Member

bennn commented Oct 15, 2024

Sounds related to #30 . It would be awesome to support more number types!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants