Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows MSVC support #78

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Add Windows MSVC support #78

merged 3 commits into from
Feb 12, 2024

Conversation

Systemcluster
Copy link
Contributor

Closes #75

MarcusDunn
MarcusDunn requested changes Feb 11, 2024
View reviewed changes
Copy link
Contributor

@MarcusDunn MarcusDunn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - good change.

instead of as _ could you reference the generated type (i.e. llama_gretype) in the struct.

@MarcusDunn MarcusDunn enabled auto-merge February 12, 2024 17:50
@MarcusDunn MarcusDunn merged commit 8d1bee2 into utilityai:main Feb 12, 2024
5 checks passed
@Systemcluster Systemcluster deleted the windows branch February 13, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusDunn MarcusDunn MarcusDunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to compile on Windows with u32 != i32
2 participants
@Systemcluster @MarcusDunn