Dotnet compilation errors when upgrading from Leaf 3.9.1 to 3.11.0

[artgoldberg]

Hi Folks

Time to turn over a new leaf, so I'm upgrading from Leaf 3.9.1 to 3.11.0. While we leave 3.9.1 running in production I'm making 3.11.0 run in dev. These steps are done:

1. Cloned the Centos VM running Leaf 3.9.1
2. Copy the production LeafDB to the dev instance of the data warehouse DBMS server
3. Execute the Leaf SQL migration scripts from 3.9.1 to 3.11.1 against the dev LeafDB
4. In the dev VM, remove any previously deployed Leaf instances (rm -r /var/opt/leafapi/api)
5. Git pull and checkout leaf commit v3.11.0
6. Try to compile the Leaf API

git shows this:

root@omop-leaf-temp:/var/opt/leafapi/leaf_download/leaf $ git status
# HEAD detached at v3.11.0
nothing to commit, working directory clean

And compilation generates this (albeit in 3 colors I can reproduce with a screenshot if that would help):

root@omop-leaf-temp:/var/opt/leafapi/leaf_download/leaf/src/server $ dotnet publish -c Debug -o /var/opt/leafapi/api
Microsoft (R) Build Engine version 16.7.2+b60ddb6f4 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
/usr/share/dotnet/sdk/3.1.408/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.DefaultItems.targets(151,5): warning NETSDK1080: A PackageReference to Microsoft.AspNetCore.App is not necessary when targeting .NET Core 3.0 or higher. If Microsoft.NET.Sdk.Web is used, the shared framework will be referenced automatically. Otherwise, the PackageReference should be replaced with a FrameworkReference. [/var/opt/leafapi/leaf_download/leaf/src/server/Tests/Tests.csproj]
/usr/share/dotnet/sdk/3.1.408/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.DefaultItems.targets(151,5): warning NETSDK1080: A PackageReference to Microsoft.AspNetCore.App is not necessary when targeting .NET Core 3.0 or higher. If Microsoft.NET.Sdk.Web is used, the shared framework will be referenced automatically. Otherwise, the PackageReference should be replaced with a FrameworkReference. [/var/opt/leafapi/leaf_download/leaf/src/server/API/API.csproj]
  All projects are up-to-date for restore.
/usr/share/dotnet/sdk/3.1.408/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.DefaultItems.targets(151,5): warning NETSDK1080: A PackageReference to Microsoft.AspNetCore.App is not necessary when targeting .NET Core 3.0 or higher. If Microsoft.NET.Sdk.Web is used, the shared framework will be referenced automatically. Otherwise, the PackageReference should be replaced with a FrameworkReference. [/var/opt/leafapi/leaf_download/leaf/src/server/Tests/Tests.csproj]
/usr/share/dotnet/sdk/3.1.408/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.DefaultItems.targets(151,5): warning NETSDK1080: A PackageReference to Microsoft.AspNetCore.App is not necessary when targeting .NET Core 3.0 or higher. If Microsoft.NET.Sdk.Web is used, the shared framework will be referenced automatically. Otherwise, the PackageReference should be replaced with a FrameworkReference. [/var/opt/leafapi/leaf_download/leaf/src/server/API/API.csproj]
  Model -> /var/opt/leafapi/leaf_download/leaf/src/server/Model/bin/Debug/netcoreapp3.1/Model.dll
  Model -> /var/opt/leafapi/api/
Cohort/CachedCohortPreparer.cs(62,43): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Cohort/CachedCohortPreparer.cs(86,44): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Compiler/LeafDbDataReader.cs(76,60): error CS0173: Type of conditional expression cannot be determined because there is no implicit conversion between '<null>' and 'Guid' [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Compiler/LeafDbDataReader.cs(77,60): error CS0173: Type of conditional expression cannot be determined because there is no implicit conversion between '<null>' and 'DateTime' [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Compiler/LeafDbDataReader.cs(79,60): error CS0173: Type of conditional expression cannot be determined because there is no implicit conversion between '<null>' and 'bool' [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Compiler/LeafDbDataReader.cs(80,60): error CS0173: Type of conditional expression cannot be determined because there is no implicit conversion between '<null>' and 'int' [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Compiler/LeafDbDataReader.cs(240,27): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Compiler/LeafDbDataReader.cs(256,60): error CS0173: Type of conditional expression cannot be determined because there is no implicit conversion between 'Guid' and '<null>' [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Compiler/LeafDbDataReader.cs(257,60): error CS0173: Type of conditional expression cannot be determined because there is no implicit conversion between 'DateTime' and '<null>' [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Compiler/LeafDbDataReader.cs(260,60): error CS0173: Type of conditional expression cannot be determined because there is no implicit conversion between 'bool' and '<null>' [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]
Compiler/LeafDbDataReader.cs(261,60): error CS0173: Type of conditional expression cannot be determined because there is no implicit conversion between 'int' and '<null>' [/var/opt/leafapi/leaf_download/leaf/src/server/Services/Services.csproj]

These warnings and errors don't make sense to me. I request your help, as I'm not a dotnet user or a c# programmer.

Thanks
Arthur

[ndobb]

Hi @artgoldberg, I'm not quite sure what to make of those errors, and am wondering if the v3.11.0 tag you pulled from is (for some unknown reason) using code that was not part of the final git commit. As you can see from the commit history on that file, LeafDbDataReader.cs, there has been one and only one commit. Moreover, when I compile the API (from master, rather than 3.11.0, but the file should be the same between them), I don't see any of the same errors:

Do you get the same errors if you compile from Leaf master?

Also, we're planning to move the UW production Leaf instance to v3.11.1 this Friday, after which I'll make a formal release for 3.11.1. The source code is very unlikely to change before then. I'd suggest using master or waiting till Friday when we make a 3.11.1 tag, as 3.11.1 fixes a few issues with Timelines and Patient List as well (and may also resolve whatever compilation issue you're running into).

[artgoldberg]

Thanks @ndobb

The master branch compiles. With warnings removed, I get:

Determining projects to restore...
  All projects are up-to-date for restore.
  Model -> /var/opt/leafapi/leaf_download/leaf/src/server/Model/bin/Release/netcoreapp3.1/Model.dll
  Model -> /var/opt/leafapi/api/
  Services -> /var/opt/leafapi/leaf_download/leaf/src/server/Services/bin/Release/netcoreapp3.1/Services.dll
  Services -> /var/opt/leafapi/api/
  API -> /var/opt/leafapi/leaf_download/leaf/src/server/API/bin/Release/netcoreapp3.1/API.dll
  API -> /var/opt/leafapi/api/
  Tests -> /var/opt/leafapi/leaf_download/leaf/src/server/Tests/bin/Release/netcoreapp3.1/Tests.dll
  Tests -> /var/opt/leafapi/api/

[artgoldberg]

Hi @ndobb

Moving ahead on this. I'd appreciate it if you could let me know when 3.11.1 is released.

Thanks
A

[ndobb]

Hi @artgoldberg please hold on for a moment - when testing late Friday we found what seems to be a bug in the patient list and are trying to determine whether it's a instance-specific configuration issue or something else. I will ping you by the EOD today as we sort it out.

Thanks for your patience.
-nic

[artgoldberg]

Hi @ndobb
I can wait. Good luck debugging it.
A