Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options object optional for Validator constructor #114

Open
simonplend opened this issue Jun 29, 2022 · 2 comments
Open

Make options object optional for Validator constructor #114

simonplend opened this issue Jun 29, 2022 · 2 comments

Comments

@simonplend
Copy link
Collaborator

Currently you must always pass an object if you're using TypeScript.

@kisankumavat85
Copy link

kisankumavat85 commented Aug 21, 2022

Hi, I want to contribute to this library. Can I add the default value of options to an empty object?

@simonplend
Copy link
Collaborator Author

Hi, I want to contribute to this library. Can I add the default value of options to an empty object?

@kisankumavat85 A pull request would be great, thanks!

I would recommend waiting until #116 has been merged as that makes some changes to the Validator class constructor that you'll need to add changes on top of (I'm currently testing it).

Feel free to Subscribe to notifications on that PR so you get notified when it's merged, but I'll also try and update this issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants