clippy

dft/src/radix_2_bowers.rs

@@ -4,7 +4,6 @@ use p3_field::{Field, Powers, TwoAdicField};
 use p3_matrix::dense::{RowMajorMatrix, RowMajorMatrixViewMut};
 use p3_matrix::util::reverse_matrix_index_bits;
 use p3_matrix::Matrix;
-use p3_maybe_rayon::prelude::*;
 use p3_util::{log2_strict_usize, reverse_bits, reverse_slice_index_bits};
 
 use crate::butterflies::{

fri/src/prover.rs

@@ -10,7 +10,7 @@ use p3_maybe_rayon::prelude::*;
 use tracing::{info_span, instrument};
 
 use crate::fold_even_odd::fold_even_odd;
-use crate::{CommitPhaseProofStep, FriConfig, FriProof, QueryProof, TwoAdicFriPcsGenericConfig};
+use crate::{CommitPhaseProofStep, FriConfig, FriProof, QueryProof};
 
 #[instrument(name = "FRI prover", skip_all)]
 pub fn prove<F, M, Challenger>(

fri/src/two_adic_pcs.rs

@@ -182,8 +182,8 @@ where
                 })
                 .collect()
         });
-        let commitment = self.mmcs.commit(ldes);
-        commitment
+
+        self.mmcs.commit(ldes)
     }
 }
 
@@ -265,8 +265,8 @@ where
         let mut num_reduced = [0; 32];
 
         let ys_outer: Vec<(&Self::ProverData, Vec<&Vec<C::Challenge>>)> = (*prover_data_and_points)
-            .into_iter()
-            .map(|(pd, cs)| (*pd, (*cs).into_iter().collect::<Vec<&Vec<C::Challenge>>>()))
+            .iter()
+            .map(|(pd, cs)| (*pd, (*cs).iter().collect::<Vec<&Vec<C::Challenge>>>()))
             .collect();
 
         let ys_outer: Vec<Vec<Vec<Vec<C::Challenge>>>> = ys_outer
@@ -298,7 +298,7 @@ where
             })
             .collect();
 
-        for (i, (data, points)) in prover_data_and_points.into_iter().enumerate() {
+        for (i, (data, points)) in prover_data_and_points.iter().enumerate() {
             let mats = self.mmcs.get_matrices(data);
             let opened_values_for_round = all_opened_values.pushed_mut(vec![]);
             for (j, (mat, points_for_mat)) in izip!(mats, *points).enumerate() {
@@ -308,7 +308,7 @@ where
                 debug_assert_eq!(reduced_opening_for_log_height.len(), mat.height());
 
                 let opened_values_for_mat = opened_values_for_round.pushed_mut(vec![]);
-                for (k, &point) in points_for_mat.into_iter().enumerate() {
+                for (k, &point) in points_for_mat.iter().enumerate() {
                     let _guard =
                         info_span!("reduce matrix quotient", dims = %mat.dimensions()).entered();