Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug report] library is not compatible with Angular v16 #1089

Closed
5 tasks done
pawelofieldly opened this issue May 5, 2023 · 9 comments
Closed
5 tasks done

[bug report] library is not compatible with Angular v16 #1089

pawelofieldly opened this issue May 5, 2023 · 9 comments

Comments

@pawelofieldly
Copy link

Dragula is not compatible with Angular 16

Steps to reproduce the behavior:

There are two scenarios:

I. You want to install dragula in ng16 project

  1. npm install --save ng2-dragula
  2. See error: unable to resolve dependency tree

II. You want to migrate current project to ng16

  1. use ng update to update ng15 to ng16
  2. See error when ng serve has been run: Error: node_modules/ng2-dragula/dist/components/dragula.module.d.ts:3:23 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s). static forRoot(): ModuleWithProviders;
@reda-alaoui
Copy link
Contributor

I made it work without any issue.

@reda-alaoui reda-alaoui closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2023
@reda-alaoui reda-alaoui pinned this issue May 11, 2023
@ohsk23
Copy link

ohsk23 commented May 16, 2023

Hi, I have a similar problem here.
ng2-dragula has dependency conflict with @angular/[email protected]

❯ npm i [email protected]                                                      took 5s
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [PROJ_NAME]@1.16.10
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/core
npm ERR!   @angular/core@"16.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/core@"15.2.9" from @angular/[email protected]
npm ERR! node_modules/@angular/animations
npm ERR!   peer @angular/animations@"^15.0.0" from [email protected]
npm ERR!   node_modules/ng2-dragula
npm ERR!     ng2-dragula@"4.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Any updates for angular v16?

@mrkava
Copy link

mrkava commented May 18, 2023

Similar problem after update to Angular 16. Do you plan to support Angular 16?

@Petronio1982
Copy link

PS C:\Users\attim\Documents\virtualroom3d> npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/animations
npm ERR! @angular/animations@"^16.0.3" from the root project
npm ERR! peer @angular/animations@"^16.0.0 || ^17.0.0" from @angular/[email protected]
npm ERR! node_modules/@angular/material
npm ERR! @angular/material@"^16.0.2" from the root project
npm ERR! peer @angular/material@"16.0.2" from @angular/[email protected]
npm ERR! node_modules/@angular/material-moment-adapter
npm ERR! @angular/material-moment-adapter@"^16.0.2" from the root project
npm ERR! 1 more (@angular/platform-browser)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/animations@"^15.0.0" from [email protected]
npm ERR! node_modules/ng2-dragula
npm ERR! ng2-dragula@"^4.0.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @angular/[email protected]
npm ERR! node_modules/@angular/animations
npm ERR! peer @angular/animations@"^15.0.0" from [email protected]
npm ERR! node_modules/ng2-dragula
npm ERR! ng2-dragula@"^4.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@onaluf
Copy link

onaluf commented Jun 2, 2023

I've got the same exact issue. If installed with --force everything works correctly so fixing this is probably as simple as updating the package.json to be a bit more flexible as to which version of angular it requires.

@pjc2007
Copy link

pjc2007 commented Jun 13, 2023

Would also like to use with Angular 16.

@pawelofieldly
Copy link
Author

@reda-alaoui do you consider updating compatibility to ng16? I would like not to use npm install --force

@neodescis
Copy link

neodescis commented Jun 17, 2023

Why is this issue closed? The current version of the project specifically lists ^15.0.0 in its peer dependencies.

@ghbob
Copy link

ghbob commented Jul 5, 2023

@valorkin @SvetlanaMuravlova Could you kindly give us some information if there are plans to make this package support Angular 16? Thank you!
Someone prepared a PR as well: #1092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants