Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add check for base description length #551

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Nov 7, 2023

Description

After merging #542 it became clear that some of our dapp descriptions where not matching the expectations set out in adding-new-dapps specifically, "Dapp descriptions must be 50 characters or less...". This PR adds a check for the dapp description in the base.json; we may want to relax this limit.

The dapps with descriptions which are above 50 characters are listed below:

{
  "bidali": "Use your crypto to purchase gift cards from brands worldwide",
  "ethichub": "Lend capital to unbanked farmers through DeFi crowdfunding",
  "halofi": "Be your best financial self. Hit your goals to get rewarded",
  "hedgey": "Empower your team and investors with on-chain token vesting",
  "immortalx": "Trade crypto with low fees directly from your wallet, with up to 50x leverage",
  "impactmarket": "Donate, stake, and collect $PACT while empowering underserved communities",
  "ipermatch": "Collect NFT footballers and be the manager of YOUR team",
  "llamaswap": "Find the best route for your trade giving you the best execution prices in DeFi", 
  "masa": "Claim a free .celo domain, refer friends and earn rewards",
  "moola": "Lend, borrow, or pool your crypto while getting rewards",
  "sarafu": "Create, use and explore Community Asset Vouchers with Grassroots Economics",
  "staked-celo": "Stake CELO and get rewards while keeping your crypto liquid",
  "talentprotocol": "Where builders commit to goals, share their progress and find the support they need to succeed",
  "toucan": "Use your crypto to create carbon credits for climate action"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant