Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport the ChainType enum from the middleware to open-autonomy #2279

Open
OjusWiZard opened this issue Nov 15, 2024 · 0 comments
Open

Backport the ChainType enum from the middleware to open-autonomy #2279

OjusWiZard opened this issue Nov 15, 2024 · 0 comments

Comments

@OjusWiZard
Copy link
Member

Is your feature request related to a problem? Please describe.
We can not seamlessly use the ChainType enum from open-autonomy in Pearl because of the following reasons:

  • In Pearl, we partially support a different LedgerType and ChainType, i.e. SOLANA
  • In Pearl, we have some more utility methods that are not present in the ChainType enum of open-autonomy

Describe the solution you'd like
It would be best to have a complete version of this ChainType enum in open-autonomy and use it in the middleware with a simple import.

  • Either add the partial implementation of SOLANA in open-autonomy, or not (if not then it'll need to be cleaned from Pearl)
  • Add the utility property/methods like ledger_type, from_string, and from_id in the ChainType of open-autonomy

Describe alternatives you've considered
For now, a dynamically mutated version of ChainType is used in the middleware. We want to avoid such workarounds.

Additional context
Once done, use the updated version of autonomy in the Pearl and remove this TODO and maybe the partial implementation of SOLANA (if we choose to do that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant