Skip to content
This repository has been archived by the owner on Nov 20, 2022. It is now read-only.

Possible security improvements #14

Open
hendursaga opened this issue Nov 22, 2021 · 2 comments
Open

Possible security improvements #14

hendursaga opened this issue Nov 22, 2021 · 2 comments

Comments

@hendursaga
Copy link

Although I see you've done an impressive job containing this program, I think it's possible to do even better, at least, on Linux. Instead of setuid root, perhaps setgid input for handling /dev/input/*? As for /dev/uinput, I'm not sure - this article adds a new group uinput as well as udev rules, but I don't think you can setgid a program for multiple groups, correct? I don't think assigning /dev/uinput to group input would be the best choice - isn't it for reading from input devices, and not writing?

Any thoughts?

@valpackett
Copy link
Owner

Is the "input group" even a universal thing across distros? I don't really use Linux so I'm generally afraid to make any such changes. (Also I don't use this project actively anymore.)

don't think you can setgid a program for multiple groups, correct?

Yeah, can't do that from the filesystem.

@hendursaga
Copy link
Author

Is the "input group" even a universal thing across distros?

I'm not entirely sure about that, but for all of my systems (Debian), it is. I was mostly talking about adding the possibility of using more restricted permissions to the end of the installation docs for users who might desire that.

As for /dev/uinput, I'm not sure how to proceed. Perhaps do what the article suggested? Right now the current group is root. Perhaps I could sometime test things out and report how well it works or doesn't?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants