Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable specific linters instead of enabling them all #1891

Closed

Conversation

alexandear
Copy link
Contributor

This PR changes golangci-lint configuration by replacing enable-all + disable specific linters with disable-all + enable specific linters. This is better because, in the case of upgrading the golangci-lint version, we don't need to fix additional lint issues introduced by the new version. Additionally, this setting is more stable because some linters are deprecated and removed from golangci-lint from time to time.

I used the command golangci-lint linters to see the list of currently enabled linters before changing the .golangci.yml file.

@erikdubbelboer
Copy link
Collaborator

To be honest I don't think this is better. I prefer new linters to automatically be enabled. If they aren't, we're going to forget about them and never enable them. I also prefer deprecated linters to automatically be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants