Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-2820 site-nav icon btns: simplify styles; fix zoom accessibility #556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WEB-2820 site-nav icon btns: simplify styles; fix zoom accessibility #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 6 additions & 25 deletions src/components/blocks/site-nav/_site-nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,15 +172,14 @@ $nav-breakpoints: (
0 0 10px 5px rgba(0, 0, 0, 5%),
0 0 50px 1px rgba(0, 0, 0, 20%),
inset 0 0 50px 4px rgba(0, 0, 0, 24%);
display: inline-block;
display: inline-flex;
height: 40px;
margin-left: 10px;
width: 40px;

> svg {
height: 16px;
margin: 11px;
width: 17px;
flex: 1;
margin: 9px;
}
}

Expand Down Expand Up @@ -219,24 +218,17 @@ $nav-breakpoints: (
&__mobile-bag,
&__core__bag {
> svg {
height: 26px;
margin: 4px 6px;
width: 24px;
margin: 1px 3px 5px;
}
}

&__core__search-btn {
> #{&}-open {
height: 22px;
margin: 7px;
width: 22px;
}

> #{&}-close {
display: none;
height: 16px;
margin: 10px;
width: 16px;
}

&--active &-open {
Expand All @@ -257,11 +249,9 @@ $nav-breakpoints: (
&__bag-total {
color: base.sitecolors-siteColor("vam-white");
font-size: 12px;
font-weight: 700;
inset: 11px 0 0;
margin: auto;
left: 15px;
position: absolute;
text-align: center;
top: 9px;
}

&__mobile-toggle {
Expand All @@ -286,15 +276,6 @@ $nav-breakpoints: (
display: none;
}

> svg {
height: 18px;
width: 18px;
}

> #{&}__icon--hamburger {
margin: 9px auto;
}

&__icon--close {
display: none;
}
Expand Down