Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GainPlugin not passing down arguments to GainImputation #42

Open
vsimkus opened this issue May 26, 2024 · 0 comments
Open

GainPlugin not passing down arguments to GainImputation #42

vsimkus opened this issue May 26, 2024 · 0 comments

Comments

@vsimkus
Copy link

vsimkus commented May 26, 2024

Hi, thanks for the package.

There's a minor bug in GainPlugin class, in that it doesn't pass down the arguments to GainImputation:

https://github.com/vanderschaarlab/hyperimpute/blob/main/src/hyperimpute/plugins/imputers/plugin_gain.py#L332-L349

To reproduce:

from hyperimpute.plugins.imputers import Imputers

n_epochs=256

gain = Imputers().get('gain', n_epochs=n_epochs)

assert gain._model.n_epochs == n_epochs, 'Argument not passed down'

Also, perhaps the name of the argument "n_epochs" in GAIN should be changed, as it is really the number of gradient steps/iterations, and not passes over the entire dataset (e.g. an epoch).

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant