Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Vanilla should display filename instead of tags for files opened outside of Vanilla #895

Open
2 of 6 tasks
prg318 opened this issue Jan 12, 2019 · 2 comments · May be fixed by #1057
Open
2 of 6 tasks
Labels
Milestone

Comments

@prg318
Copy link

prg318 commented Jan 12, 2019

  • Vanilla Music Version (Settings -> About): 1.0.80
  • Android Version: 9.0
  • Phone vendor / model: Google Pixel XL (128GB)
  • Application was downloaded from (use [x]):
    • Play Store
    • F-Droid
    • Other (Nightly Build)
  • Did this work in a previous version?
    • Yes
    • No
    • NA / Don't know.

Description

When playing an untagged file before vanilla has gotten a chance to index it, the statusbar notification and vanilla application will show an empty title and empty artist for the track. Once vanilla has finished indexing the media library, the filename will be used as the title. However - it would be great for vanilla to just use the filename when tags are not available. When playing recently downloaded podcasts, it's inconvenient to index the entire phone's memory in order to show the filename in the statusbar.

#591 was opened and closed after the reporter realized he could reindex.. However this is not a good solution for the use case of a user wanting to open a newly downloaded empty tagged audio file in Vanilla
....

Steps to reproduce the issue

  1. Add an audio file with empty tags to your phone (download a Video using NewPipe for example)
  2. Open the audio file in a file browser (or in the case of the NewPipe example, simply hit "play" on the downloaded file in "Downloads")
  3. Select to open the file in "Vanilla Music Player" if its not the already associated default
  4. Notice how both the Vanilla UI and the statusbar controls/notification do not display the filename at all
    ...

Distinction (edit!)

Even AFTER the file has been indexed by Vanilla, vanilla will NOT use the filename if the file is opened from a File Manager or other application (such as NewPipe). The filename is only used when the file is actually opened from the Vanilla Music Player library itself

@andiandi13
Copy link

I would rename the issue to "Vanilla should display filename instead of tags for non-indexed files"

@prg318 prg318 changed the title [Suggestion] Vanilla should display filename instead of tags when no tags present [Suggestion] Vanilla should display filename instead of tags for files opened outside of Vanilla Jan 12, 2019
@prg318
Copy link
Author

prg318 commented Jan 12, 2019

I would rename the issue to "Vanilla should display filename instead of tags for non-indexed files"

After my most recent discovery (and edit in the Distinction section) I changed the title. Thanks - I hope this clears things up. Basically even after indexing, vanilla will use the nonexistant tags for files opened in Vanilla via Android's "open with..." dialog

I apologize I don't know the Android terminology for some of this

@adrian-bl adrian-bl added the bug label Apr 21, 2019
@adrian-bl adrian-bl added this to the 1.0.90 milestone Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants