Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundant code #375

Open
KartikVerma0 opened this issue Oct 10, 2024 · 2 comments
Open

Reduce redundant code #375

KartikVerma0 opened this issue Oct 10, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@KartikVerma0
Copy link

Is your feature request related to a problem? Please describe.
There are several pieces of code that are redundant and are not necessary like in utils file you have externalInjection function which is used in index.js to import appconfig which can be directly imported

Describe the solution you'd like
I would like to clear out redundant code

Describe alternatives you've considered
like use require function to directly import json file rather than making custom externalInjection function

Additional context
Add any other context or screenshots about the feature request here.

@KartikVerma0 KartikVerma0 added the enhancement New feature or request label Oct 10, 2024
@KartikVerma0
Copy link
Author

I think reducing redundant code can make it simpler for developers to understand the code base, and I would like to work on this issue.

@vasani-arpit
Copy link
Owner

Yes. webhooks used to be called from chrome itself so that that time config was needed there, earlier version of puppeteer wasn't supporting direct code injection so had to write util for that.

Feel free to make a PR for whatever you think is extra or unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants