Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work for browsers #7

Open
vbakke opened this issue Jan 3, 2018 · 1 comment
Open

Make it work for browsers #7

vbakke opened this issue Jan 3, 2018 · 1 comment
Assignees
Labels

Comments

@vbakke
Copy link
Owner

vbakke commented Jan 3, 2018

I have not yet tried including this in a browser.

Buffer.from(...) must be replaced by TextDecoder().
Feel free to add other browser issues if you try that road.

Aim is that this must work in both NodeJS and browsers.

@vbakke vbakke added the bug label Jan 3, 2018
@vbakke vbakke self-assigned this Jan 7, 2018
@vbakke
Copy link
Owner Author

vbakke commented Jan 7, 2018

I'll use browserify to bridge the gap to browsers.

Also, the browser TextEncoder() has deprecated support for encopdeing text as UTF-16 (or actually, anything but UTF-8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant