Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inversion fixes and improvements #157

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Inversion fixes and improvements #157

wants to merge 23 commits into from

Conversation

ivankokan
Copy link
Contributor

Resolves #143.

@ivankokan
Change prototype of inversion inversion(circle c1, circle c2, real sg…
40e097a 
…n = 1)
@ivankokan
Minor edit: inversion(circle c1, circle c2, circle c3) transforms
635e25a
@ivankokan
Add missing optional real argument to signature
0c6f9d0
@ivankokan
Abort radicalcenter(circle,circle) for concentric circles (so as in r…
b072889 
…adicalline(circle,circle))
@ivankokan
Remove invalid check within radicalcenter(circle,circle)
ce7947f
@ivankokan
Prettify radicalcenter(circle,circle)
3f8006d
@ivankokan
Revisit and refactor all inverse functions and corresponding operators
e7907c3
@ivankokan
Align with inversion(circle,circle,real) and avoid redundant inversio…
ba13a5b 
…n call
@ivankokan
Revisit struct inversion
7c3fef1
@ivankokan
Change prototype of lineinversion function and consolidate its usage
aed6e16
@ivankokan
Simplify power of a point operator ^(point,explicit circle)
8f0b889
@ivankokan
Edit: inversion radius -> inversion power
7a82751
@ivankokan
Remove unused variable
b22478c
@ivankokan
TODO remarks on radical* functions for degenerate circle(s)
b77998e
@ivankokan
Enhance radicalcenter(circle,circle) preserving the current behavior
6b5d52b
@johncbowman johncbowman marked this pull request as ready for review January 5, 2022 20:43
johncbowman added a commit that referenced this pull request Jan 5, 2022
@johncbowman
Merge pull request #157 from ivankokan: Inversion fixes and improveme…
7f8a998 
…nts.
@johncbowman
Copy link
Member

Merged in commit 7f8a998.

@johncbowman johncbowman closed this Jan 5, 2022
@ivankokan
Copy link
Contributor Author

I'd rather unmerge this. Still not finished, but hopefully I will find some time in a month.

johncbowman added a commit that referenced this pull request Jan 5, 2022
@johncbowman
Revert "Merge pull request #157 from ivankokan: Inversion fixes and i…
f2cce72 
…mprovements."

This reverts commit 7f8a998.
@johncbowman johncbowman reopened this Jan 5, 2022
@johncbowman johncbowman marked this pull request as draft January 5, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inversion(circle1, circle2) in geometry.asy not always correct
2 participants
@ivankokan @johncbowman