Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Issue with Vaftire Module #59

Open
kylecannon opened this issue Sep 24, 2013 · 0 comments
Open

Performance Issue with Vaftire Module #59

kylecannon opened this issue Sep 24, 2013 · 0 comments
Labels

Comments

@kylecannon
Copy link
Member

Not sure if this was present on 1.35 but on version 2 just having fitments without any tire fitments and only using the year make model program i ran xhprof and without disabling I was getting a total call time of 5,518,485 microseconds.

Doing the following decreased the page view time to 2,711,977 microseconds

VF/Singleton.php

    /**
     * store paramaters in the session
     * @return integer fit_id
     */
    function storeFitInSession()
    {
        $search = $this->flexibleSearch();
        $mapping_id = $search->storeFitInSession();

//        if (file_exists(ELITE_PATH . '/Vaftire')) {
//            $tireSearch = new Elite_Vaftire_Model_FlexibleSearch($search);
//            $tireSearch->storeTireSizeInSession();
//        }
//        if (file_exists(ELITE_PATH . '/Vafwheel')) {
//            $wheelSearch = new Elite_Vafwheel_Model_FlexibleSearch($search);
//            $wheelSearch->storeSizeInSession();
//        }
//        if (file_exists(ELITE_PATH . '/Vafwheeladapter')) {
//            $wheeladapterSearch = new Elite_Vafwheeladapter_Model_FlexibleSearch($search);
//            $wheeladapterSearch->storeAdapterSizeInSession();
//        }
        return $mapping_id;
    }

I narrowed it down to Elite_Vaftire_Model_FlexibleSearch::storeTireSizeInSession taking an extra 2,712,798 microseconds to process the search block.
screen shot 2013-09-24 at 12 36 46 pm

screen shot 2013-09-24 at 12 37 00 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant