Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS no check on actions page #20

Open
ThahaShahzad opened this issue Apr 14, 2024 · 2 comments
Open

TS no check on actions page #20

ThahaShahzad opened this issue Apr 14, 2024 · 2 comments

Comments

@ThahaShahzad
Copy link

Is gemini not fully supported for generative UI? Could we fix this page to be type safe?

@ruru-m07
Copy link

@ThahaShahzad I want to work it but I need more details what you want. Also I open 2 PR in this repo but no one review it.

Soo I think they stop make changes in this repo.

But I can still help you give me more information about your issue 😊

@odysseaspapadimas
Copy link

@ThahaShahzad It's easily fixable:

  • Update all necessary aiState maps
const history = aiState.get().messages.map((message: Message) => ({ //The Message type
    role: message.role,
    content: message.content
  }))
  • Go to the types.ts and update the Chat interface messages prop to point to that same type from actions.tsx

I think that's it? All of the flight components and stuff are very wrongly typed and I don't plan to use them so I just removed them

Slighly unrelated but since you kind of mentioned it @ruru-m07. The deployed app isn't even stable and it's really easily fixable, but I really wouldn't want to waste time creating PRs for a project that doesn't even check PRs, much less is maintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants