Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: verified_contracts match related constraints #17

Merged
merged 3 commits into from
Sep 18, 2024
Merged

test: verified_contracts match related constraints #17

merged 3 commits into from
Sep 18, 2024

Conversation

rimrakhimov
Copy link
Contributor

  • Add tests for verified_contracts constraints related to matches integrity
  • Fix failing creation_values and runtime_values constraints when NULL value is inserted

@kuzdogan kuzdogan self-assigned this Sep 16, 2024
kuzdogan
kuzdogan requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@kuzdogan kuzdogan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do one additional test. Otherwise lgtm

tests/test_table_verified_contracts.py Show resolved Hide resolved
@rimrakhimov rimrakhimov merged commit 8e59e3e into master Sep 18, 2024
1 check passed
@rimrakhimov rimrakhimov deleted the rimrakhimov/test-match-constraints branch September 18, 2024 11:56
@rimrakhimov rimrakhimov restored the rimrakhimov/test-match-constraints branch September 18, 2024 11:57
@rimrakhimov rimrakhimov deleted the rimrakhimov/test-match-constraints branch September 18, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzdogan kuzdogan kuzdogan approved these changes

@marcocastignoli marcocastignoli Awaiting requested review from marcocastignoli

@samczsun samczsun Awaiting requested review from samczsun

Assignees

@kuzdogan kuzdogan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rimrakhimov @kuzdogan