Rx Version of OAuth2AuthHandler Handler fails to add scopes

[pendula95]

Version

4.5.7

Context

Rx Version of OAuth2AuthHandler Handler fails to send correct scopes. This happens because during initialization of the OAuth2AuthHandler object new instance is ignored because of how rx code is generated.

Do you have a reproducer?

Yes please find the reproducer attached https://gist.github.com/pendula95/0460494f9f6bacaf6ec8e5c63473fe70

This is because of following lines:

vertx-web/vertx-web/src/main/java/io/vertx/ext/web/handler/OAuth2AuthHandler.java

Lines 78 to 87 in 03f75d5

	/**
	* Return a <b>new instance</b> with the internal state copied from the caller but the scopes to be requested during
	* a token request are unique to the instance. When scopes are applied to the handler, the default scopes from the
	* route metadata will be ignored.
	*
	* @param scope scope.
	* @return new instance of this interface.
	*/
	@Fluent
	OAuth2AuthHandler withScope(String scope);

vertx-web/vertx-web/src/main/java/io/vertx/ext/web/handler/OAuth2AuthHandler.java

Lines 90 to 98 in 03f75d5

	* Return a <b>new instance</b> with the internal state copied from the caller but the scopes to be requested during
	* a token request are unique to the instance. When scopes are applied to the handler, the default scopes from the
	* route metadata will be ignored.
	*
	* @param scopes scopes.
	* @return new instance of this interface.
	*/
	@Fluent
	OAuth2AuthHandler withScopes(List<String> scopes);

Generated RX Class looks like this:

  public io.vertx.rxjava3.ext.web.handler.OAuth2AuthHandler withScopes(java.util.List<java.lang.String> scopes) { 
    delegate.withScopes(scopes);
    return this;
  }
  public io.vertx.rxjava3.ext.web.handler.OAuth2AuthHandler withScope(java.lang.String scope) { 
    delegate.withScope(scope);
    return this;
  }

This results in delegate never updating with new config.

[pendula95]

Some insight why this behavior was introduced #2219 (comment)

[tsegismont]

As a workaround, you can create a new instance of the Rxified handler using the object returned by getDelegate().withScope(scope)

In Vert.x 5, the problem is fixed by #2413

In Vert.x 4, I believe we should remove the @fluent annotations from the relevant methods.

Fine with you @vietj ?