-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile.Advice.json: Expand on $profile paths #420
Conversation
- expand on $profile possibilities (different PSHosts) - expand on changes IDEs make on $profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! 💖
There's one or two small things that I think we should alter a little but other than that, this looks fantastic. Thanks! 😊 🌸
"CurrentUserAllHosts", | ||
"CurrentUserCurrentHost", | ||
"\n", | ||
"Different PSHosts (applications hosting a powershell process) like IDEs have custom profiles paths that are referenced by $profile. While the default $profile will be available in every environment, it is useful to know where IDEs save their profiles. Customizations only required for e.g. development can be added.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Different PSHosts (applications hosting a powershell process) like IDEs have custom profiles paths that are referenced by $profile. While the default $profile will be available in every environment, it is useful to know where IDEs save their profiles. Customizations only required for e.g. development can be added.", | |
"Different PSHosts (applications hosting a powershell process) like IDEs have custom profile paths that are referenced by $profile. While the default $profile will be available in every environment, it is useful to know where IDEs save their profiles. Customizations only required for e.g. development can be added.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fixed now, thanks :)
"Powershell ISE uses $profile, but with a custom path pointing to a Microsoft.PowerShellISE_profile.ps1 file.", | ||
"Visual Studio Code uses $profile, but with a custom path pointing to a Microsoft.VSCode_profile.ps1 file." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should clarify these custom paths are incorporated into the "current host" variants of the profile paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Added another sentence to explain the same behaviour.
- fix typo profiles --> profile - expand on default scope and PSHost of $profile in IDEs
PR Summary
Expand on Profile Advice as asked in #260
Context
Changes
only textual changes with different possibilities where $profile can point to
Checklist