Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile.Advice.json: Expand on $profile paths #420

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

Maamue
Copy link
Contributor

@Maamue Maamue commented Oct 26, 2020

PR Summary

Expand on Profile Advice as asked in #260

Context

  • expand on $profile possibilities (different PSHosts)
  • expand on changes IDEs make on $profile

Changes

only textual changes with different possibilities where $profile can point to

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

- expand on $profile possibilities (different PSHosts)
- expand on changes IDEs make on $profile
@vexx32 vexx32 self-assigned this Oct 27, 2020
@vexx32 vexx32 added the Category-Advice 🗨️ Related to Advice cmdlets or library label Oct 27, 2020
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 💖

There's one or two small things that I think we should alter a little but other than that, this looks fantastic. Thanks! 😊 🌸

"CurrentUserAllHosts",
"CurrentUserCurrentHost",
"\n",
"Different PSHosts (applications hosting a powershell process) like IDEs have custom profiles paths that are referenced by $profile. While the default $profile will be available in every environment, it is useful to know where IDEs save their profiles. Customizations only required for e.g. development can be added.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Different PSHosts (applications hosting a powershell process) like IDEs have custom profiles paths that are referenced by $profile. While the default $profile will be available in every environment, it is useful to know where IDEs save their profiles. Customizations only required for e.g. development can be added.",
"Different PSHosts (applications hosting a powershell process) like IDEs have custom profile paths that are referenced by $profile. While the default $profile will be available in every environment, it is useful to know where IDEs save their profiles. Customizations only required for e.g. development can be added.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now, thanks :)

Comment on lines 16 to 17
"Powershell ISE uses $profile, but with a custom path pointing to a Microsoft.PowerShellISE_profile.ps1 file.",
"Visual Studio Code uses $profile, but with a custom path pointing to a Microsoft.VSCode_profile.ps1 file."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should clarify these custom paths are incorporated into the "current host" variants of the profile paths.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Added another sentence to explain the same behaviour.

@vexx32 vexx32 added the hacktoberfest-accepted PRs that have been accepted for Hacktoberfest label Oct 27, 2020
- fix typo profiles --> profile
- expand on default scope and PSHost of $profile in IDEs
@vexx32 vexx32 merged commit 953aa77 into vexx32:main Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Advice 🗨️ Related to Advice cmdlets or library hacktoberfest-accepted PRs that have been accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants