-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace OrderedDictionary
from Microsoft.Experimental.Collections with the BCL type in .NET 9+
#43
Comments
OrderedDictionary
from Microsoft.Collections.ExtensionsOrderedDictionary
from Microsoft.Experimental.Collections
It may be worth considering simply not using an ordered dictionary here. When writing the data center file, attributes get sorted anyway. So, creating a data center in memory, writing it, and reading it back, the attributes will not have the same order as they did in memory during creation. It's not clear that using an ordered dictionary here actually adds much value. Moving this for consideration in v2.0. |
Postponing after all. A major issue is that unpacking a data center would result in 'random' attribute order, whereas right now, attributes are ordered as they appear in the data center, which results in a mostly (though not always) intuitive order. We could order attributes explicitly by key status and name, but that won't cover all cases well. |
Good news: dotnet/runtime#24826 is now on track to being implemented. We will do this when we bump our minimum TFM to |
OrderedDictionary
from Microsoft.Experimental.CollectionsOrderedDictionary
from Microsoft.Experimental.Collections with BCL OrderedDictionary
in .NET 9+
OrderedDictionary
from Microsoft.Experimental.Collections with BCL OrderedDictionary
in .NET 9+OrderedDictionary
from Microsoft.Experimental.Collections with the BCL type in .NET 9+
novadrop/src/formats/formats.csproj
Lines 5 to 6 in 8e0d7f2
novadrop/src/formats/formats.csproj
Lines 23 to 25 in 8e0d7f2
Blocked on:
net10.0
#132The text was updated successfully, but these errors were encountered: