Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient HandleGraph to JSON conversion #4448

Open
adamnovak opened this issue Nov 19, 2024 · 0 comments
Open

Efficient HandleGraph to JSON conversion #4448

adamnovak opened this issue Nov 19, 2024 · 0 comments

Comments

@adamnovak
Copy link
Member

GraphPeakCaller needs a JSON-format graph input, but vg convert can't make that. Only vg view can make that, and if the input is a generic HandleGraph it gets copied into vg::VG format and then JSON-ified into a string in memory and then printed.

} else if (output_type == "json") {
cout << pb2json(vg_graph->graph) << endl;

We need to be able to efficiently convert graphs to JSON that GraphPeakCaller understands.

GraphPeakCaller doesn't seem to do any path rank reconstruction, so we might also need to make sure we can output paths in their entirety, unlike how we chunk them in the Protobuf representation. (It also seems to want to load all the JSON into memory again.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant