Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider droping check for container type in add_keywords_from_list #127

Open
GrazingScientist opened this issue Dec 6, 2021 · 0 comments

Comments

@GrazingScientist
Copy link

Although the name of the function clearly states that it expects a list, add_keywords_from_list should take any container.

In the implementation, the only thing done is to loop over the given list. However, this would also be possible with a set with no change in behavior. Is there a reason why it has to be a list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant