Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonar issues in the sonarquest code itself #161

Open
aabeling opened this issue Nov 28, 2018 · 1 comment
Open

Fix sonar issues in the sonarquest code itself #161

aabeling opened this issue Nov 28, 2018 · 1 comment
Assignees
@Christoph-Meyer
Labels
help wanted A good starting point if you are new with the code

Comments

@aabeling
Copy link
Contributor

The sonarquest code itself has several sonar issues when analyzed against our profiles (which are relatively common and sensible).

E.g.

  • a lot of log statements are reported because of squid:S3457
  • the package name does not comply with naming convention squid:S00120
  • @RequestMapping should be replaced by @PostMapping, @GetMapping, etc
@Christoph-Meyer Christoph-Meyer added bug An error that needs to be fixed help wanted A good starting point if you are new with the code labels Dec 3, 2018
Christoph-Meyer pushed a commit that referenced this issue Dec 17, 2018
@aabeling @Christoph-Meyer
Issue161 (#169)
36db4fb 
* issue #161: made packages all lower case

* issue #161: replaced @RequestMapping with @GetMapping, @PostMapping, @PutMapping, @DeleteMapping

* issue #161: fixed log statements, squid:S3457

* issue #161: fixed some more easy sonar issues
@Christoph-Meyer Christoph-Meyer self-assigned this Feb 27, 2019
@Christoph-Meyer
Copy link
Collaborator

I will look into it

fkoehne added a commit that referenced this issue Feb 27, 2019
@fkoehne
More Sonar code smells removed, i.e. #161.
ae13c34
@Christoph-Meyer Christoph-Meyer removed the bug An error that needs to be fixed label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Christoph-Meyer Christoph-Meyer

Labels
help wanted A good starting point if you are new with the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aabeling @Christoph-Meyer