From 127eff77f8ba22cbddc7aa45d78f76ddc3688b16 Mon Sep 17 00:00:00 2001 From: Christian24 Date: Wed, 19 Sep 2018 11:58:31 +0200 Subject: [PATCH 1/5] Update issue templates Added bug report template Added feature request template --- .github/ISSUE_TEMPLATE/bug_report.md | 32 ++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..b1ad7162 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,32 @@ +--- +name: Bug report +about: Create a report to help us improve + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Desktop (please complete the following information):** + - Maven version + - Java version + - Browser [e.g. chrome, safari] + - Version [e.g. 2.7.0] + + + +**Additional context** +Add any other context about the problem here. From d742994b2f190a6ea3813ccada5f4e82a9c5ebca Mon Sep 17 00:00:00 2001 From: Tobias Bell Date: Mon, 7 Jan 2019 16:49:51 +0100 Subject: [PATCH 2/5] Fix JavaDelegate doc The implementation only checks for interface implementation in its direct inheritance. This is ok, if the name of the delegate contains AbstractBpmnActivityBehavior --- docs/JavaDelegateChecker.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/JavaDelegateChecker.md b/docs/JavaDelegateChecker.md index ad44ba79..d5ce226c 100644 --- a/docs/JavaDelegateChecker.md +++ b/docs/JavaDelegateChecker.md @@ -5,6 +5,7 @@ Service Tasks, Send Tasks, Receive Tasks, Script Tasks or Business Rule Tasks: - Wrong reference to Java Class - Wrong reference in Bean mapping - Wrong or no interfaces (Needs to be *JavaDelegate*, *SignallableActivityBehavior*, *AbstractBpmnActivityBehavior*) +- If delegate does not implement one of the interfaces directly it needs to contain the string "AbstractBpmnActivityBehavior" in its name - Interface *ActivityBehaviour* should not be used - No reference to a Java Class or Delegate (Bean) - No implementation specified From defafb26ba577fc67165e9628cf428e8fe3bcc3f Mon Sep 17 00:00:00 2001 From: sdibernardo Date: Tue, 15 Jan 2019 10:55:06 +0100 Subject: [PATCH 3/5] Update JavaDelegateChecker.md --- docs/JavaDelegateChecker.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/JavaDelegateChecker.md b/docs/JavaDelegateChecker.md index d5ce226c..6bd30c75 100644 --- a/docs/JavaDelegateChecker.md +++ b/docs/JavaDelegateChecker.md @@ -5,7 +5,7 @@ Service Tasks, Send Tasks, Receive Tasks, Script Tasks or Business Rule Tasks: - Wrong reference to Java Class - Wrong reference in Bean mapping - Wrong or no interfaces (Needs to be *JavaDelegate*, *SignallableActivityBehavior*, *AbstractBpmnActivityBehavior*) -- If delegate does not implement one of the interfaces directly it needs to contain the string "AbstractBpmnActivityBehavior" in its name +- If delegate does not implement one of the interfaces directly it needs to extend the class "AbstractBpmnActivityBehavior" - Interface *ActivityBehaviour* should not be used - No reference to a Java Class or Delegate (Bean) - No implementation specified From b08368825083410e874a3ba154ce675961c1f963 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frank=20K=C3=B6hne?= Date: Thu, 17 Jan 2019 12:53:11 +0100 Subject: [PATCH 4/5] Note regarding Soot license included. --- docs/README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/README.md b/docs/README.md index 84b97d77..9df69d01 100644 --- a/docs/README.md +++ b/docs/README.md @@ -349,12 +349,15 @@ Status of the development branch: [![Build Status](https://travis-ci.org/viadee/ ## Licenses All licenses of reused components can be found on the [maven site](http://rawgit.com/viadee/vPAV/master/docs/MavenSite/project-info.html) -
Additionally we use the following third-party dependencies, that are not distributed via maven: + +
Additionally we use the following third-party dependencies, that are not covered via maven-found licences: - [BPMN.io](https://bpmn.io/license/) tool under the bpmn.io license. - [Bootstrap](https://github.com/twbs/bootstrap/blob/v4-dev/LICENSE) licensed under MIT - [jQuery](https://jquery.org/license/) licensed under MIT - [PopperJS](https://github.com/FezVrasta/popper.js/blob/master/LICENSE.md) licensed under MIT +- [Soot](https://github.com/Sable/soot) licensed under a LGPL 2.1 license +Soot and bpmn.io provide the basis for the two most exciting features of the validator, i.e. finding inconsistencies in the data and control flow across model and code an the visualization thereof. We would like explicitly thank these two communities for their contiued effort. **BSD 3-Clause License**
From 7055b521d3725479b62d61c999343486ea8b16d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frank=20K=C3=B6hne?= Date: Thu, 17 Jan 2019 12:54:08 +0100 Subject: [PATCH 5/5] Typo fixed. --- docs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/README.md b/docs/README.md index 9df69d01..ae4b4a68 100644 --- a/docs/README.md +++ b/docs/README.md @@ -357,7 +357,7 @@ All licenses of reused components can be found on the [maven site](http://rawgit - [PopperJS](https://github.com/FezVrasta/popper.js/blob/master/LICENSE.md) licensed under MIT - [Soot](https://github.com/Sable/soot) licensed under a LGPL 2.1 license -Soot and bpmn.io provide the basis for the two most exciting features of the validator, i.e. finding inconsistencies in the data and control flow across model and code an the visualization thereof. We would like explicitly thank these two communities for their contiued effort. +Soot and bpmn.io provide the basis for the two most exciting features of the validator, i.e. finding inconsistencies in the data and control flow across model and code an the visualization thereof. We would like to explicitly thank these two communities for their continued effort. **BSD 3-Clause License**