Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

204 Response: Return empty string instead of true #3

Open
mfrister opened this issue Dec 10, 2015 · 0 comments
Open

204 Response: Return empty string instead of true #3

mfrister opened this issue Dec 10, 2015 · 0 comments

Comments

@mfrister
Copy link
Contributor

Currently, we return true as return value for the request method when the server returns status 204.

To be consistent with non-empty non-JSON responses, we should return an empty string.

@tobischo Do you think this is a good idea?
@mfrister mfrister changed the title 204 Resposne: Return empty string instead of true 204 Response: Return empty string instead of true Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfrister