Skip to content

Latest commit

 

History

History
90 lines (59 loc) · 3.76 KB

CONTRIBUTING.md

File metadata and controls

90 lines (59 loc) · 3.76 KB
Raw

Contributing

Anyone is welcome to help with Firefox Accounts. Feel free to get in touch with other community members on Matrix, the mailing list or through issues here on GitHub.

UPDATE: On March 2020, Mozilla moved from IRC to Matrix. For more information on Matrix, check out the following wiki article: https://wiki.mozilla.org/Matrix.

Bug Reports

You can file issues here on GitHub. Please try to include as much information as you can and under what conditions you saw the issue.

Sending Pull Requests

Patches should be submitted as pull requests (PR).

Before submitting a PR:

  • Your code must run and pass all the automated tests before you submit your PR for review. "Work in progress" pull requests are allowed to be submitted, but should be clearly labeled as such and should not be merged until all tests pass and the code has been reviewed.
    • Run grunt eslint to make sure your code passes linting.
    • Run npm test to make sure all tests still pass.
  • Your patch should include new tests that cover your changes. It is your and your reviewer's responsibility to ensure your patch includes adequate tests.

When submitting a PR:

  • You agree to license your code under the project's open source license (MPL 2.0).
  • Base your branch off the current main (see below for an example workflow).
  • Add both your code and new tests if relevant.
  • Run grunt eslint and npm test to make sure your code passes linting and tests.
  • Please do not include merge commits in pull requests; include only commits with the new relevant code.
  • Your commit message must follow the commit guidelines.

After your PR is merged:

  • Add yourself to the AUTHORS file so we can publicly recognize your contribution.

See the main README.md for information on prerequisites, installing, running and testing.

Code Review

This project is production Mozilla code and subject to our engineering practices and quality standards. Every patch must be peer reviewed. This project is part of the Firefox Accounts module, and your patch must be reviewed by one of the listed module owners or peers.

Example Workflow

This is an example workflow to make it easier to submit Pull Requests. Imagine your username is user1:

  1. Fork this repository via the GitHub interface

  2. The clone the upstream (as origin) and add your own repo as a remote:

    $ git clone https://github.com/mozilla/fxa-auth-db-mysql.git
$ cd fxa-auth-db-mysql
$ git remote add user1 [email protected]:user1/fxa-auth-db-mysql.git

  3. Create a branch for your fix/feature and make sure it's your currently checked-out branch:

    $ git checkout -b add-new-feature

  4. Add/fix code, add tests then commit and push this branch to your repo:

    $ git add <files...>
$ git commit
$ git push user1 add-new-feature

  5. From the GitHub interface for your repo, click the Review Changes and Pull Request which appears next to your new branch.

  6. Click Send pull request.

Keeping up to Date

The main reason for creating a new branch for each feature or fix is so that you can track main correctly. If you need to fetch the latest code for a new fix, try the following:

$ git checkout main
$ git pull

Now you're ready to branch again for your new feature (from step 3 above).