Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow theming of the completion popup window. #48

Open
jordwalke opened this issue Jul 29, 2013 · 3 comments
Open

Allow theming of the completion popup window. #48

jordwalke opened this issue Jul 29, 2013 · 3 comments

Comments

@jordwalke
Copy link

I hear there is some special casing in Vico's code that tries to match the color scheme. (I'd love a link to that part of the code). Some might think that's a little too magical (and I agree) but I think most people would definitely settle for it to be controlled by a special colorscheme property. That might be easier as well.

@Shadowfiend
Copy link
Member

The relevant code (commented out) is @ https://github.com/vicoapp/vico/blob/master/app/ViCompletionController.m#L64 . There's no clear indication as to why it was commented out, but I'm guessing it wasn't working quite as intended/complete.

Are you thinking a color scheme specifically for the controller, or are you thinking you could specify the colors in all color schemes with a set of properties for the color schemes?

I could go for the latter, where we would fall back on some default properties from the scheme when the special properties weren't present.

@jordwalke
Copy link
Author

Yes, the latter (being able to specify them in color schemes) - special properties in the Textmate colorscheme file that no other editor pays regard to.

@Shadowfiend
Copy link
Member

Sounds solid. I think it should be reasonably straightforward.

@fjl fjl mentioned this issue Feb 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants