Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST: Search multiple paths for songs #286

Open
RecursiveFunctions opened this issue Dec 21, 2023 · 3 comments
Open

FEATURE REQUEST: Search multiple paths for songs #286

RecursiveFunctions opened this issue Dec 21, 2023 · 3 comments

Comments

@RecursiveFunctions
Copy link

RecursiveFunctions commented Dec 21, 2023

Given the limited storage space of micro SD cards for Raspberry Pis, it'd be great if Pikaraoke could also search external drives or even other hosts on the same network.

Ideally, if I plug in an external sdd to my pi, pikaraoke should be able to detect that automatically. if my friend also happens to bring his usb stick full of his own songs and plugs it in, pikaraoke should be able to list songs from both sources.

I considered using aufs to combine multiple mount points into one such that pikaraoke would be able to access songs from each of them as if it was one directory.

another possible alternative would be to have Pikaraoke take in multiple paths and search them. maybe make a list?

I think the former implementation would not be compatible with windows, but the latter should be cross-platform.

Edit:
looks like using mount --bind would also work (for linux)
https://www.phind.com/search?cache=mxx94g0k82mc3rtetkm5hedw

@vicwomg
Copy link
Owner

vicwomg commented Dec 23, 2023

On the point of limited SD storage space, why not just change the default download directory to your mounted drive with the -d option?

To implement multiple search paths in a cross-platform way, probably want to add a separate CLI parameter that can take a comma-separated list of additional paths and add them to the initial startup scan.

@RecursiveFunctions
Copy link
Author

On the point of limited SD storage space, why not just change the default download directory to your mounted drive with the -d option?

I would, but I run into the path handling problem #287 since my drive has a space in the name.

To implement multiple search paths in a cross-platform way, probably want to add a separate CLI parameter that can take a comma-separated list of additional paths and add them to the initial startup scan.

-p --paths maybe? I'll use that as a placeholder unless/until there's a better name

Having it separate from -d is also good because maybe the user wants downloaded songs to at specific location separate from their collection.

@vicwomg
Copy link
Owner

vicwomg commented Dec 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants