Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Only allow one connection at a time to the splash page #321

Closed
frankchau93 opened this issue Mar 17, 2024 · 1 comment
Closed

Comments

@frankchau93
Copy link

I noticed when there is a splash page currently live and if another browser decides to go to the same splash page, it messes up the current splash page since the logic in the other splash page is triggering songs to play through the queue. I'm wondering if there's a good way to improve the splash page from being messed with. Maybe with a cookie or a code?

@vicwomg vicwomg changed the title [FEATURE] Better security for splash page [FEATURE] Only allow one connection at a time to the splash page Mar 17, 2024
@vicwomg
Copy link
Owner

vicwomg commented Dec 26, 2024

Looked into it, and it's not really trivial to limit connections in this way.

I think a better solution would be to simply allow multiple splash screen connections, but keep them in better sync. Seems like a valid use case that a user might want the splash screen to show on multiple clients.

Filed: #448

@vicwomg vicwomg closed this as completed Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants