Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for UK version #2

Open
mtaun01 opened this issue Dec 28, 2020 · 3 comments
Open

Support for UK version #2

mtaun01 opened this issue Dec 28, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mtaun01
Copy link

mtaun01 commented Dec 28, 2020

Hi. It would be great if, once the driver for the US version of the HEM-Gen5 is done, you could enhance the driver to add support for the UK HEM-Gen5. I have a UK single-phase (1 clamp) gen 5 device purchased a couple of weeks ago and also the latest C7 Hubitat purchased a couple of months ago and am happy to help with testing on my setup when the time comes.

@mtaun01 mtaun01 added the enhancement New feature or request label Dec 28, 2020
@viertaxa
Copy link
Owner

I've requested the Engineering Sheet from Aeotec to make sure there are no major differences. I'm not expecting anything, but I want to be sure. I'll create a single phase variant as soon as I have that sheet.

@viertaxa viertaxa self-assigned this Dec 28, 2020
@viertaxa
Copy link
Owner

Commit deef974 on the main branch introduces alpha support for the 1 Phase variant. All in all, it basically amounted to a bunch of deletions in the code that should make things run a bit smoother and reduce the Z-Wave traffic on the network.

You can grab the driver here.

There should be no need to remove and re-add the device to Hubitat/Z-Wave. Just copy the driver code from the RAW view and paste it over top of the existing driver that you have for the 2 phase version.

If you don't experience any issues, I'll move this to BETA status and it will start tracking with the 2-Phase version in terms of features.

Please let me know how it goes.

@mtaun01
Copy link
Author

mtaun01 commented Dec 29, 2020

Thanks Taylor. It works just fine. I note one tiny thing that I think might be a minor non-disruptive bug (more of a clean-up). The UK Aeotec only has a single clamp, in fact the connection points on the case where in other versions clamps 2 and 3 are connected are blanked off on my UK 1-phase device so extra clamps aren't even an add-on item as far as I can tell. The Preferences section in the driver however still has pairs of "Wattage Report Triggers" and "Wattage Percent Report Trigger" for "(Clamp 1)" and "(Both Clamps Combined)". Do those "(Both Clamps Combined)" preferences have any function on the single-clamp model? If not it would reduce clutter and potential user confusion to remove those "(Both Clamps Combined)" preferences.

Also, in the 1-phase readme file it says "THIS DRIVER IS FOR THE ZW095-A ONLY". That seems to be a cut and paste from the 2-phase readme. I am looking at the box my HEM came in and in the UK the model number is listed as "ZW095-C (868.42MHz)". I'm not sure if the A/C difference is related to the 1 vs 2 phase or if maybe in Europe Z-Wave is allocated a different frequency but in any event on the basis of my successful testing so far I suggest you at least add ZW095-C to the supported model numbers or maybe replace the A with a C if it was a simple cut and paste error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants