Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play Next" causes bitrate change #99

Open
joerosenthal opened this issue Jun 25, 2023 · 2 comments
Open

"Play Next" causes bitrate change #99

joerosenthal opened this issue Jun 25, 2023 · 2 comments

Comments

@joerosenthal
Copy link

Clicking "Play next" on a 96kbps song while a 44.1khz song is playing switches the bitrate.

@drpoutine
Copy link

Observed this as well.
Sometimes the bitrate will not change until you click somewhere in the progress bar and it changes back to the correct sampling rate.

Unsure if the new beta app has a debugging log to see where it fails.

@waszqba
Copy link

waszqba commented Oct 25, 2023

The original description is a bit short and got me thinking if this is the issue I'm having, so a bit more verbose description of my case:

Context:

  • M1 Max machine with Sonoma 14.0 running 1.1 build 16 (beta11)
  • Bit depth switching enabled

Issues:

  • Sometimes LSS misses the switch for a new song when going from 44.1/16 to 48/24 on a playlist without skipping
  • even when the next song has the same rate/depth, LSS sometimes switches to the next next song's params
  • skipping to the next song with different depth/rate is a hit or miss:
    • LSS can ignore the new bitrate altogether
    • LSS can switch to the correct depth/rate but then switch to the previous one

What fixes the rates and depths:

  • scrolling through the song fixes the rates

Overall thoughts

The switching itself is quite efficient and works fine, but the detection mechanism seems to struggle and that's where we should investigate. If I find some spare time I'll try to tinker around with it and maybe submit a PR with a fix but I can't promise anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants