Fix #123: simpler pagination with .pages() without first .get #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjsj
changed the title
fjsj
force-pushed
the
fix-123-simple-pages
branch
from
523afd4
to
ede522f
Compare
| else: | ||
| # this mean .pages() was called before the first .get, | ||
| # like `api.statuses_user_timeline().pages()` | ||
| response = self.get(params=params) |
There was a problem hiding this comment.
Shouldn't we simply pass all the kwargs?
Passing only the params will limit the options that can be passed in the request, a header for example.
| "Pass params on the .get call instead.") | ||
| executor = self | ||
| else: | ||
| # this mean .pages() was called before the first .get, |
| def pages(self, max_pages=None, max_items=None, params=None, **kwargs): | ||
| if self._response is not None: | ||
| if params is not None: | ||
| raise Exception("Since you're paging after the first .get call, " |
There was a problem hiding this comment.
Just improving the message:
You cannot pass new params after the first request is done. Use the ".get" method to pass parameters
|
Closing because this would be a major change in API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123