Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default bevy features for Quill #20

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PROMETHIA-27
Copy link
Contributor

Now vortex should be working.

@PROMETHIA-27 PROMETHIA-27 changed the title Disable default features for Quill Disable default bevy features for Quill Aug 12, 2024
@PROMETHIA-27
Copy link
Contributor Author

One moment, the revert means it seems like the original changes aren't here, I'll see if I can revert-revert

@PROMETHIA-27
Copy link
Contributor Author

Ok, everything should be prepared again I think.

@connorgmeehan
Copy link

👍 this change! Build size is a big concern for my app. On that topic, one thing that I'd like to contribute (if you think it's appropriate @viridia) would be making bevy_ui an optional default in bevy_quill_core. However if you don't want to deal with maintenance burden I'm happy to do this in a fork.

@viridia
Copy link
Owner

viridia commented Aug 28, 2024

I'm open to this; the original PR had some compatibility issues and I haven't gotten around to testing/rebasing the new one - been a bit distracted lately.

Separating bevy_quill_core from bevy_ui might be a challenge. It's kind of hard to tell how bad the dependencies are due to how many places I import bevy::prelude.

@viridia
Copy link
Owner

viridia commented Aug 28, 2024

The place where Quill core depends on bevy_ui the most is the dependency path that runs through bevy_mod_stylebuilder. You'd basically have to make styles an optional feature or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants