Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #13

Open
virresh opened this issue Oct 15, 2020 · 4 comments
Open

Add tests #13

virresh opened this issue Oct 15, 2020 · 4 comments
Labels
hacktoberfest help wanted Extra attention is needed

Comments

@virresh
Copy link
Owner

virresh commented Oct 15, 2020

Currently there are no tests whatsoever.

It'd be great if someone can help adding unit, integration and end-to-end tests.
Any contribution in this regard will be appreciated.

@virresh virresh added help wanted Extra attention is needed hacktoberfest labels Oct 15, 2020
@EEM86
Copy link

EEM86 commented Oct 26, 2020

@virresh helo, I can work on it. I'm going to work at java_client. What classes do you prefer to cover with tests first? Assign me to this task if your pleasure).

@virresh
Copy link
Owner Author

virresh commented Oct 28, 2020

Hi @EEM86,

Thanks a lot for volunteering!

The java_client has been deprecated and is present for legacy purposes (noted in README here).

However, I'd like to recommend you the Python version. If you're even a bit comfortable with Python, you can start looking at https://github.com/virresh/StockD/blob/master/python_client/app/routes.py
The core logic lies in that single python file itself.

The application is mainly based on a web-development framework flask, so all the UI-handling portion is done through html-css in static folder.

Since there isn't any existing test framework in use, feel free to use any framework if you feel comfortable in that.

Also, let me know if you're taking up the task of python testing, I'll assign you then :D

@EEM86
Copy link

EEM86 commented Oct 28, 2020

@virresh Oh, I'm terribly sorry. I read the README file but missed the info that java_client is deprecated. Unfortunately, I'm not familiar with Python, but I have it on my to-do list. So, maybe next time, when I'll be ready for Python tasks...

@virresh
Copy link
Owner Author

virresh commented Oct 28, 2020

sure, no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants