Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test greenboot ci #3

Closed
wants to merge 1 commit into from
Closed

test greenboot ci #3

wants to merge 1 commit into from

Conversation

henrywang
Copy link
Contributor

No description provided.

@henrywang
Copy link
Contributor Author

/greenboot-rs-test-rawhide say-paul/images:remove-old-greenboot-services

@henrywang
Copy link
Contributor Author

/greenboot-rs-test-rawhide say-paul/images:remove-old-greenboot-services

@henrywang
Copy link
Contributor Author

/greenboot-rs-test-rawhide say-paul/images:remove-old-greenboot-services

@henrywang
Copy link
Contributor Author

/greenboot-rs-test-rawhide say-paul/images:remove-old-greenboot-services

1 similar comment
@yih-redhat
Copy link
Contributor

/greenboot-rs-test-rawhide say-paul/images:remove-old-greenboot-services

@yih-redhat
Copy link
Contributor

/greenboot-rs-test-rawhide yih-redhat/images:image-ci

1 similar comment
@yih-redhat
Copy link
Contributor

/greenboot-rs-test-rawhide yih-redhat/images:image-ci

@yih-redhat
Copy link
Contributor

/greenboot-rs-test-rawhide yih-redhat/images:image-ci

say-paul
say-paul reviewed Oct 11, 2023
View reviewed changes
greenboot-test/greenboot-rs.sh Outdated
@@ -32,7 +32,7 @@ SSH_KEY=key/ostree_key

# Set os-variant and boot location used by virt-install.
case "${ID}-${VERSION_ID}" in
"fedora-"*"")
"fedora-"*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure as why its failing here, the regex seems to be working for me in rhel

#!/bin/bash
ID="fedora"
VERSION_ID=40
case "${ID}-${VERSION_ID}" in
        "fedora-"*)
                echo "match"
                ;;
        *)

        echo "mismatch"
esac

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be try after removing " , which also worked for me.

@yih-redhat
Copy link
Contributor

/greenboot-rs-test-rawhide yih-redhat/images:image-ci

@yih-redhat
Copy link
Contributor

/greenboot-rs-test-39 yih-redhat/images:image-ci

@yih-redhat yih-redhat force-pushed the greenboot_ci branch 2 times, most recently from 9bc115a to 45208eb Compare October 12, 2023 14:02
@yih-redhat
Copy link
Contributor

/greenboot-rs-test-39 say-paul/images:remove-old-greenboot-services

@yih-redhat
Copy link
Contributor

/greenboot-rs-test-39 say-paul/images:remove-old-greenboot-services

@yih-redhat
Copy link
Contributor

/greenboot-rs-test-39 say-paul/images:remove-old-greenboot-services

@yih-redhat
Copy link
Contributor

/greenboot-rs-test-39 say-paul/images:remove-old-greenboot-services

@yih-redhat
Copy link
Contributor

/greenboot-rs-test-39 say-paul/images:remove-old-greenboot-services

@henrywang henrywang closed this Jan 2, 2024
@henrywang henrywang deleted the greenboot_ci branch January 2, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@say-paul say-paul say-paul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrywang @yih-redhat @say-paul