Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading fails in a linked docker container #116

Open
tcharlat opened this issue Dec 24, 2015 · 3 comments
Open

Reloading fails in a linked docker container #116

tcharlat opened this issue Dec 24, 2015 · 3 comments

Comments

@tcharlat
Copy link

I have some trouble fixing a bug.

I created a docker image and I wish to use http-master as a sub-domain router.
I link the proxy to another docker, the routing is fine, everything is ok.

If I modify the http-master.conf file, the reloading kicks in, seems fine.

Reloading workers due to config change
[1] Reloading config
[1] Listening on port: port 80
[1] Start successful
All workers reloaded, downtime was 8ms

Except that now the proxy is not responding.

Here is a repo with more details and how to reproduce the bug https://github.com/Kallikrein/http-master-issue

@Nowaker
Copy link
Member

Nowaker commented Dec 31, 2015

Hi @Kallikrein, thanks for your report. Unfortunately, we won't have time to work on your problem now, and can't even give you a time frame. If you're able to find the problem and submit a PR, we'll gladly accept it. Thanks.

@tcharlat
Copy link
Author

@Nowaker I have been tinkering and added some debug logs to monitor the relaod process in action and couldn't find why the reload fails. I don't have the first clue on a PR so I am giving up.

Restarting a proxy container is highly simplified by the new network pattern of docker that deprecated linking containers, so I deactivated the auto-reload and restart myself when config changes.

I'll keep digging when I can gather enough time and when I will have the necessary understanding I am obviously currently lacking.

Thanks for your hard work and dedication.

@krlicmuhamed
Copy link

Hi @Kallikrein, any luck on running http-master as a docker container?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants